'Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo
From:       "Laurent Navet" <laurent.navet+kde () gmail ! com>
Date:       2014-01-10 20:49:33
Message-ID: 20140110204933.28498.34160 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114933/
-----------------------------------------------------------

(Updated Jan. 10, 2014, 9:49 p.m.)

Review request for KDE Examples and Sune Vuorela.

Changes
-------

fix QIcon issue, also adjust CMakelist (no need to find Dbus, Script and Tests packages)

Repository: kdeexamples

Description
-------

This is part of Google Code-IN Contest.
As I'm no more student, I've waited for the end of the contest to work on it.

Comments appreciated,

Diffs (updated)
-----

  kdeui/kmessagewidgetdemo/CMakeLists.txt 12ef4ac 
  kdeui/kmessagewidgetdemo/main.cpp d3a5bf0 
  kdeui/kmessagewidgetdemo/window.h d3a67c8 
  kdeui/kmessagewidgetdemo/window.cpp 9786da6 

Diff: https://git.reviewboard.kde.org/r/114933/diff/

Testing
-------

Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit I've commented the line.

Thanks,

Laurent Navet

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114933/">https://git.reviewboard.kde.org/r/114933/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Examples and Sune Vuorela.</div>
<div>By Laurent Navet.</div>

<p style="color: grey;"><i>Updated Jan. 10, 2014, 9:49 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">fix QIcon issue, also adjust CMakelist (no need to find Dbus, Script and \
Tests packages)</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeexamples
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is part of Google Code-IN Contest. As I&#39;m no more student, \
I&#39;ve waited for the end of the contest to work on it.

Comments appreciated,</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Regression on KTextedit::setClickMessage(), as it don&#39;t exist in \
QTextEdit I&#39;ve commented the line.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kdeui/kmessagewidgetdemo/CMakeLists.txt <span style="color: \
grey">(12ef4ac)</span></li>

 <li>kdeui/kmessagewidgetdemo/main.cpp <span style="color: \
grey">(d3a5bf0)</span></li>

 <li>kdeui/kmessagewidgetdemo/window.h <span style="color: \
grey">(d3a67c8)</span></li>

 <li>kdeui/kmessagewidgetdemo/window.cpp <span style="color: \
grey">(9786da6)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114933/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 