'Re: Review Request 114687: Allow the user of baloosearch to specify limit,'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 114687: Allow the user of baloosearch to specify limit,
From:       "Vishesh Handa" <me () vhanda ! in>
Date:       2013-12-28 12:04:50
Message-ID: 20131228120450.18800.74216 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114687/#review46253
-----------------------------------------------------------

Ship it!

Looks good to me.

- Vishesh Handa

On Dec. 28, 2013, 11:50 a.m., Levente Kurusa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114687/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2013, 11:50 a.m.)
> 
> 
> Review request for Baloo and Vishesh Handa.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> This is a GCI task.
> http://www.google-melange.com/gci/task/view/google/gci2013/5908724015169536
> 
> 
> Diffs
> -----
> 
>   src/tools/baloosearch/main.cpp 9013223 
> 
> Diff: https://git.reviewboard.kde.org/r/114687/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Levente Kurusa
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114687/">https://git.reviewboard.kde.org/r/114687/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me.</pre>  \
<br />

<p>- Vishesh Handa</p>

<br />
<p>On December 28th, 2013, 11:50 a.m. UTC, Levente Kurusa wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Levente Kurusa.</div>

<p style="color: grey;"><i>Updated Dec. 28, 2013, 11:50 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a GCI task. \
http://www.google-melange.com/gci/task/view/google/gci2013/5908724015169536</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/tools/baloosearch/main.cpp <span style="color: grey">(9013223)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114687/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 