From kde-devel Sat Mar 02 19:21:26 2013 From: Michael Pyne Date: Sat, 02 Mar 2013 19:21:26 +0000 To: kde-devel Subject: Re: a little typo bug (again) in kde-workspace/libs/ksysguard/processcore/process.cpp Message-Id: <31696405.YHLvP5e4vp () midna> X-MARC-Message: https://marc.info/?l=kde-devel&m=136225212531664 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6458216332957514538==" --===============6458216332957514538== Content-Type: multipart/signed; boundary="nextPart8477317.khsTNMUDZz"; micalg="pgp-sha256"; protocol="application/pgp-signature" Content-Transfer-Encoding: quoted-printable --nextPart8477317.khsTNMUDZz Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Friday, March 01, 2013 04:39:37 =C3=96mer Fad=C4=B1l USTA wrote: > at line 253 : > void KSysGuard::Process::setVmURSS(qlonglong _vmURSS) { > if(vmURSSChange !=3D 0 || vmURSSChange !=3D 0) >=20 > in this if statement both parts are checking same condition > i think one of them should be different like : > if(vmURSSChange !=3D 0 || vmURSS !=3D 0) Thanks for the report! You might have wanted to report it as a bug at=20= bugs.kde.org so that it doesn't get missed, most KDE developers don't r= ead=20 kde-devel. However I have patched it for the 4.10.2 release (not the upcoming 4.10= .1, the=20 one after). Regards, - Michael Pyne --nextPart8477317.khsTNMUDZz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAABCAAGBQJRMlE8AAoJEAuvDJx7aunykmcP/2dsPZOkIr6pjGy7z74IOsKc dJoR5zgLZDK8IARqp5V3eM+bchl5zz62gc7kT4Q5qSzHIsQxTJfUycr9xTNSgjnA +3SYndBd4egBRCU6IqOPJx4aSFjyq3jp663zfBe7sHHk8qIhUsMIJwfIiknT34CI m2uMS2/ih5uznVFOopH0s7HbcQioaHScdMrAkO9w5lngotJBmtph3lASVRaI1Mpo fYLlGrEQTP0/RyFJoihkIbUcq0x5iGFzmJNY/wQiKcyJOuHO86lNsJlB+nQjgxPT LFGQ1eiWkqr9MHmz3mwfhPG/GnJgf+2hx8XfpD95LhjkoxielXyyuCdXhTaz5APn 3knpSYQ01vcMMo//pdglpIiwKle97IaB/ZOF3R5fkducg3yXBjQcEKxPnMhYEEml HpVhhkwRoAxCY0nTqSqaifqOZbGVVcLu6agvF0H2qH7zasQhuYFHGZCJFPVeZ5hx qdrBpfCOMHhMrSIl6dJ7OCn6LOvEe4fYPeH7qU9QF5lW0Bb7g2nwUc4yaUg+YIKz Fmx4rmfp3cl7fPKwpzftyAkkRYbzSOL4Xc16sHar/j1WsYOt5peri8BDVnOGaiZm fl9ynC+/07/ML1ygHXRP/NYVQDDmLJv5no3ChRYi8c2dEZ2zpjE8H8PhKCnFoE2S tScOxsNyp4tv0+tU4/d5 =+F0R -----END PGP SIGNATURE----- --nextPart8477317.khsTNMUDZz-- --===============6458216332957514538== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============6458216332957514538==--