[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Dragon Player- Junior Job
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2013-02-10 21:43:54
Message-ID: 2220137.yugO8ku1z8 () xps
[Download RAW message or body]

El Dilluns, 11 de febrer de 2013, a les 01:50:05, Anmol Ahuja va escriure:
> As my first contribution to KDE, I decided to work on the (only) dragon
> player junior job, because it looked pretty simple.
> I'm supposed to add a status-bar toggle to the settings menu:
> https://bugs.kde.org/show_bug.cgi?id=288323
> 
> I tried modifying the code, adding a statusbar toggle by modifying the
> menubar toggle code (using KStandardAction)-
> (PATCH<http://pastebin.com/9zj2E8Vj>
> 1).
> But it just wouldn't work.

The name of your action and the name of the item in the .rc file have to 
match, otherwise no magic can happen.

> 
> Then I tried adding it like a normal KAction, using an the Object name  I
> declared in the .rc file (<Action name="options_show_statusbar"/>), but it
> just wouldn't show up in the settings menu, until I tried using an existing
> name, "unique", and then it magically appeared.
> 
> And another strange thing, when I randomly tried ObjectName as
> "show_status", (PATCH2 <http://pastebin.com/TnR4Sz4h>), it appeared in the
> Toolbar. I don't quite understand how, though. Is it some standard KDE
> thing?
> 
> Could someone please help me through my first patch?

Any reason you are not using KStandardAction::showStatusbar?

Cheers,
  Albert

P.S: Dragon is evil by using noMerge="1" in its menubar but i guess you're not 
the one i should complain about that :D

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]