[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Nepomuk Tags kioslave - Please Review
From:       Vishesh Handa <me () vhanda ! in>
Date:       2012-11-29 11:59:02
Message-ID: CAOPTMKCcGCvL6o1bfexopX+XQag3Pq1FPFW6SWCF7JW8fAyznQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Fri, Nov 23, 2012 at 12:57 AM, Albert Astals Cid <aacid@kde.org> wrote:

> El Dijous, 22 de novembre de 2012, a les 10:27:41, David Faure va escriure:
> > On Thursday 22 November 2012 00:24:12 Albert Astals Cid wrote:
> > > El Dimecres, 21 de novembre de 2012, a les 16:15:01, David Faure va
> >
> > escriure:
> > > > On Wednesday 07 November 2012 02:27:17 Albert Astals Cid wrote:
> > > > > Ahh, you mean copying from file: to tags:
> > > > Moving from file: to tags:, rather.
> > >
> > > Right
> > >
> > > > > I see... I'd like to hear David's opinion on how that is going to
> be
> > > > > fixed
> > > > > at  the kio/kioslave level.
> > > >
> > > > Not at that level. Apps should be able to call move and end up with a
> > > > move.
> > >
> > > Even if that means destroying the file into hyperspace?
> >
> > Well, kioslaves were meant to be V*FS*. A file system doesn't lose files
> > into hyperspace :)
>
> Sure, but it's still Virtual ;-)
>
> > However we already have a number of settings for "this or that
> functionality
> > isn't supported by this kioslave". Hmm, I wonder, what does tags:/ do in
> > put()? Where does it "write the file", if it's only a virtual collection
> of
> > stuff?
>
> Not sure, but i understand it adds the tag of the url you are in to the
> file
> you are dropping.
>
>
> >
> > If put() isn't supported, then moving (by get+put) won't be supported.
> > Only copyFromFile would be possible, which is exactly what you need,
> isn't
> > it?
>
> Ah, interesting, maybe copyFromFile is what Vishesh needs? Vishesh does it
> make sense dropping urls to tags:/ from something different than file:/ ?
>

No. It doesn't.

Theoretically one can tag anything but for now I only want to support files.


> Cheers,
>   Albert
>
> >
> > In other words, try not implementing put, if that makes sense, and let me
> > know what doesn't work.
> >
> > > > But the fix is to let drag-n-drop trigger a copy rather than allowing
> > > > the
> > > > user to select "move". The quick fix for that is
> > > > http://www.davidfaure.fr/2012/konq_operations.cpp.diff
> > > > Which hardcodes the protocol name, but at least it gets the job done.
> > > >
> > > > If we agree about this on principle, then the next step to make it
> > > > generic
> > > > could be to add another field in .protocol files, say
> > > > forceDropAction=(copy|move)
> > > > The fact that kio_trash needs forceDropAction=move shows that this
> might
> > > > make sense, we already have two users for this setting.
> > >
> > > I guess that works for me, since apps won't probably ever call "move"
> into
> > > a tags: url
> >
> > OK. But let's keep this solution under the arm for now, until we find out
> > about put() above.
> >
> > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe
> > >> <<
>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe <<
>



-- 
Vishesh Handa

[Attachment #5 (text/html)]

<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Nov 23, 2012 at \
12:57 AM, Albert Astals Cid <span dir="ltr">&lt;<a href="mailto:aacid@kde.org" \
target="_blank">aacid@kde.org</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> El Dijous, 22 de novembre de 2012, a les 10:27:41, David \
Faure va escriure:<br> <div class="im">&gt; On Thursday 22 November 2012 00:24:12 \
Albert Astals Cid wrote:<br> &gt; &gt; El Dimecres, 21 de novembre de 2012, a les \
16:15:01, David Faure va<br> &gt;<br>
&gt; escriure:<br>
&gt; &gt; &gt; On Wednesday 07 November 2012 02:27:17 Albert Astals Cid wrote:<br>
&gt; &gt; &gt; &gt; Ahh, you mean copying from file: to tags:<br>
&gt; &gt; &gt; Moving from file: to tags:, rather.<br>
&gt; &gt;<br>
&gt; &gt; Right<br>
&gt; &gt;<br>
&gt; &gt; &gt; &gt; I see... I&#39;d like to hear David&#39;s opinion on how that is \
going to be<br> &gt; &gt; &gt; &gt; fixed<br>
&gt; &gt; &gt; &gt; at  the kio/kioslave level.<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; Not at that level. Apps should be able to call move and end up with \
a<br> &gt; &gt; &gt; move.<br>
&gt; &gt;<br>
&gt; &gt; Even if that means destroying the file into hyperspace?<br>
&gt;<br>
&gt; Well, kioslaves were meant to be V*FS*. A file system doesn&#39;t lose files<br>
&gt; into hyperspace :)<br>
<br>
</div>Sure, but it&#39;s still Virtual ;-)<br>
<div class="im"><br>
&gt; However we already have a number of settings for &quot;this or that \
functionality<br> &gt; isn&#39;t supported by this kioslave&quot;. Hmm, I wonder, \
what does tags:/ do in<br> &gt; put()? Where does it &quot;write the file&quot;, if \
it&#39;s only a virtual collection of<br> &gt; stuff?<br>
<br>
</div>Not sure, but i understand it adds the tag of the url you are in to the \
file<br> you are dropping.<br>
<div class="im"><br>
<br>
&gt;<br>
&gt; If put() isn&#39;t supported, then moving (by get+put) won&#39;t be \
supported.<br> &gt; Only copyFromFile would be possible, which is exactly what you \
need, isn&#39;t<br> &gt; it?<br>
<br>
</div>Ah, interesting, maybe copyFromFile is what Vishesh needs? Vishesh does it<br>
make sense dropping urls to tags:/ from something different than file:/ \
?<br></blockquote><div><br>No. It doesn&#39;t.<br><br>Theoretically one can tag \
anything but for now I only want to support files.<br><br></div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">

<br>
Cheers,<br>
  Albert<br>
<div class="im HOEnZb"><br>
&gt;<br>
&gt; In other words, try not implementing put, if that makes sense, and let me<br>
&gt; know what doesn&#39;t work.<br>
&gt;<br>
&gt; &gt; &gt; But the fix is to let drag-n-drop trigger a copy rather than \
allowing<br> &gt; &gt; &gt; the<br>
&gt; &gt; &gt; user to select &quot;move&quot;. The quick fix for that is<br>
&gt; &gt; &gt; <a href="http://www.davidfaure.fr/2012/konq_operations.cpp.diff" \
target="_blank">http://www.davidfaure.fr/2012/konq_operations.cpp.diff</a><br> &gt; \
&gt; &gt; Which hardcodes the protocol name, but at least it gets the job done.<br> \
&gt; &gt; &gt;<br> &gt; &gt; &gt; If we agree about this on principle, then the next \
step to make it<br> &gt; &gt; &gt; generic<br>
&gt; &gt; &gt; could be to add another field in .protocol files, say<br>
&gt; &gt; &gt; forceDropAction=(copy|move)<br>
&gt; &gt; &gt; The fact that kio_trash needs forceDropAction=move shows that this \
might<br> &gt; &gt; &gt; make sense, we already have two users for this setting.<br>
&gt; &gt;<br>
&gt; &gt; I guess that works for me, since apps won&#39;t probably ever call \
&quot;move&quot; into<br> &gt; &gt; a tags: url<br>
&gt;<br>
&gt; OK. But let&#39;s keep this solution under the arm for now, until we find \
out<br> &gt; about put() above.<br>
&gt;<br>
</div><div class="HOEnZb"><div class="h5">&gt; &gt;&gt; Visit <a \
href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub" \
target="_blank">http://mail.kde.org/mailman/listinfo/kde-devel#unsub</a> to \
unsubscribe<br> &gt; &gt;&gt; &lt;&lt;<br>
<br>
&gt;&gt; Visit <a href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub" \
target="_blank">http://mail.kde.org/mailman/listinfo/kde-devel#unsub</a> to \
unsubscribe &lt;&lt;<br> </div></div></blockquote></div><br><br clear="all"><br>-- \
<br><span style="color:rgb(192,192,192)">Vishesh Handa</span><br><br> </div>



>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic