[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] Fix buttons accessibility in KMenuEdit (Bug296682)
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2012-11-22 19:25:06
Message-ID: 1601685.G4kli83WBG () xps
[Download RAW message or body]

El Dijous, 22 de novembre de 2012, a les 08:55:00, Jekyll Wu va escriure:
> 于 2012年11月22日 02:05, Julien 写道:
> > Hi,
> > 
> > This is a patch for the bug https://bugs.kde.org/show_bug.cgi?id=296682
> > 
> > It prevents to make buttons as inactive after having deleted or cutted an
> > item.
> > 
> > Thus, this bug does not only concern the delete button after having
> > deleted
> > an item, but also the following buttons : cut and copy, after having
> > deleted OR cutted an item.
> > 
> > It's my first patch submit :), I wanted to post it in the ReviewBoard, but
> > it seems that the Kmenuedit group does not exist.
> > 
> > Thanks
> 
> Aha.
> 
> Just for the record, I posted a similar review request a few weeks ago
> at https://git.reviewboard.kde.org/r/105778/ . Unfortunately, nobody
> gave a single comment :(
> 
> So there are two problems :
> 
> 1. there is no dedicated maintainer for kmenuedit. Is there?

Don't think so

> 2. there is no appropriate group for kmenuedit on reviewboard. Plasma
> devs are neither suitable nor interested in reviewing patches for
> kmenuedit.

Right, so you should have complained instead of adding the plasma group :-) We 
can create a kde-workspace group (for non plasma stuff) and assign it here or 
k-c-d, what do you guys think?

Cheers,
  Albert

> 
> As for the patch, no objection from me.
> 
> Regards
> Jekyll
> 
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
> >> <<

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]