[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    [PATCH] Fix buttons accessibility in KMenuEdit (Bug296682)
From:       Julien <frajibe () gmail ! com>
Date:       2012-11-21 18:05:18
Message-ID: CACcrsABRn8QE49uS2_GX52ap3ce_NhDjvoT7pBGKzn+cuuZ1=g () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi,

This is a patch for the bug https://bugs.kde.org/show_bug.cgi?id=296682

It prevents to make buttons as inactive after having deleted or cutted an
item.

Thus, this bug does not only concern the delete button after having deleted
an item, but also the following buttons : cut and copy, after having
deleted OR cutted an item.

It's my first patch submit :), I wanted to post it in the ReviewBoard, but
it seems that the Kmenuedit group does not exist.

Thanks

[Attachment #5 (text/html)]

Hi,<div><br></div><div>This is a patch for the bug <a \
href="https://bugs.kde.org/show_bug.cgi?id=296682" \
target="_blank">https://bugs.kde.org/show_bug.cgi?id=296682</a></div><div><br></div><div>It \
prevents to make buttons as inactive after having deleted or cutted an item.</div>

<div><br></div><div>Thus, this bug does not only concern the delete button after \
having deleted an item, but also the following buttons : cut and copy, after having \
deleted OR cutted an item.</div><div><br></div><div>It&#39;s my first patch submit \
:), I wanted to post it in the ReviewBoard, but it seems that the Kmenuedit group \
does not exist.</div> <div><br></div><div>Thanks</div>

--047d7b6221ea74b90104cf05310f--


["patch.diff" (application/octet-stream)]

diff --git a/kmenuedit/treeview.cpp b/kmenuedit/treeview.cpp
index f43ed1d..b144b1c 100644
--- a/kmenuedit/treeview.cpp
+++ b/kmenuedit/treeview.cpp
@@ -1208,10 +1208,6 @@ void TreeView::cut()
 {
     copy( true );
 
-    m_ac->action("edit_cut")->setEnabled(false);
-    m_ac->action("edit_copy")->setEnabled(false);
-    m_ac->action("delete")->setEnabled(false);
-
     // Select new current item
     // TODO: is this completely redundant?
     setCurrentItem(currentItem());
@@ -1419,9 +1415,6 @@ void TreeView::del()
 
     del(item, true);
 
-    m_ac->action("edit_cut")->setEnabled(false);
-    m_ac->action("edit_copy")->setEnabled(false);
-    m_ac->action("delete")->setEnabled(false);
     // Select new current item
     // TODO: is this completely redundant?
     setCurrentItem(currentItem());


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]