[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Nepomuk Tags kioslave - Please Review
From: Vishesh Handa <me () vhanda ! in>
Date: 2012-11-07 0:49:43
Message-ID: CAOPTMKAPzon0YOK-sKWnCS0WQ2VEyw5MiXk7cCnVGdF-g5itxQ () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Wed, Nov 7, 2012 at 6:00 AM, Albert Astals Cid <aacid@kde.org> wrote:
> El Dimecres, 7 de novembre de 2012, a les 05:51:45, Vishesh Handa va
> escriure:
> > On Wed, Nov 7, 2012 at 5:36 AM, Albert Astals Cid <aacid@kde.org> wrote:
> > > El Dimarts, 6 de novembre de 2012, a les 18:30:27, Albert Astals Cid va
> > >
> > > escriure:
> > > > El Dimarts, 6 de novembre de 2012, a les 18:17:29, Vishesh Handa va
> > >
> > > escriure:
> > > > > Ping?
> > > > >
> > > > > I'll be merging this on Thursday. I would appreciate it if somone
> > > > > could
> > > > > review the code.
> > > >
> > > > I'll have a look later today (based on my 0 knowledge of nepomuk &
> > >
> > > friends).
> > >
> > > Had a look to the code and to my knowledge it seems that it does not do
> > > any
> > > ultra silly thing, also it's a kioslave so people won't use it unless
> they
> > > want so in case it is horribly broken the "bad stuff" it can do it is
> > > pretty
> > > limited (just don't use the kioslave and done!)
> > >
> > > So i'd say go ahead.
> > >
> > > I'm curious with what you mean with "loosing" in "You can move files
> into
> > > a
> > > tag folder thereby effectively loosing them" though. Could you give
> some
> > > more
> > > info?
> >
> > The file will be deleted.
>
> Ok, that's bad, i'm vetoing on that then. Deleting user files is the worst
> thing ever, even if it is in a "exotic" kioslave.
>
Couldn't I still merge it and then work on the bug fix before it is
officially released?
>
> > From what I understand KIO does moves by copy +
> > delete.
>
> That's not true, try moving a 4GB file to from a folder to another in the
> file:/
> kioslave and you see that it actually "moves" the file, not copies and
> deletes
> it (basically the operation is instantaneous instead of taking ages)
>
I think the behaviour I described is across two different kio slaves.
>
> > The copy operation results in the corresponding tags being applied,
> > and the delete operation then deletes the file. The correct behaviour in
> > our case would be to either only allow copy operations or convert move
> > operations into copy operations.
>
> Why does the tags: kioslave even knows how to delete files? What's the
> point of
> it? If i am using the tags: kioslave i would understand i'm just working on
> tags and not on file content.
>
The tags kioslave doesn't delete the file. It's the "file" kioslave that
deletes it.
Deleting a file from the tags kioslave results in that tag being removed.
> Cheers,
> Albert
>
> >
> > We'll need to introduce some new kio flags to fix this. At least that's
> > what I understood from my discussion with David.
> >
> > > Cheers,
> > >
> > > Albert
> > >
> > > > Cheers,
> > > >
> > > > Albert
> > > >
> > > > P.S: You sent the email to the wrong list, we do reviews in
> > >
> > > kde-core-devel
> > >
> > > > not kde-devel
> > > >
> > > > > On Wed, Oct 31, 2012 at 3:12 AM, Vishesh Handa <me@vhanda.in>
> wrote:
> > > > > > Hey everyone
> > > > > >
> > > > > > I recently wrote a 'tags' kio slave, which allows one to browse
> > >
> > > nepomuk
> > >
> > > > > > tags, and the files containing those tags. It is currently in
> > > > > > kde-runtime/nepomuk/kioslaves/tags/, in the nepomuk/tagsKioSlave
> > >
> > > branch.
> > >
> > > > > > Could someone please review it? I would like to merge it before
> the
> > >
> > > hard
> > >
> > > > > > freeze.
> > > > > >
> > > > > > It has a custom url naming scheme -
> > > > > >
> > > > > > *tags:/tag1* => All the files tagged with 'tag1' and additional
> tags
> > > > > > which can be used filter the results.
> > > > > >
> > > > > > *tags:/tag1/file_url_of_the_file* => This is the url of the file.
> > > > > > Ideally
> > > > > > I would just use the normal url of the file, but we need to have
> the
> > > > > > 'tags'
> > > > > > protocol, so that we can handle delete events. We don't want to
> > >
> > > delete
> > >
> > > > > > the
> > > > > > file, rather just remove that tag.
> > > > > >
> > > > > > This file_url_of_the_file is added as the UDS_NAME, and results
> in
> > >
> > > the
> > >
> > > > > > search results looking slightly ugly if the file properties are
> > >
> > > checked.
> > >
> > > > > > Is
> > > > > > there a better way of handling this?
> > > > > >
> > > > > > *tags:/tag1/tag2 *=> Files tagged with both tag1 and tag2
> > > > > >
> > > > > > Known problems -
> > > > > > * You can move files into a tag folder thereby effectively
> loosing
> > >
> > > them
> > >
> > > > > > * No automatic updates
> > > > > > * It shows the tags with the nepomuk icon. We need a better
> 'tags'
> > >
> > > icon.
> > >
> > > > > > --
> > > > > > Vishesh Handa
> > > > >>
> > > > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> > >
> > > unsubscribe
> > >
> > > > >> <<
> > > >>
> > > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> > >
> > > unsubscribe <<
>
--
Vishesh Handa
[Attachment #5 (text/html)]
<br><br><div class="gmail_quote">On Wed, Nov 7, 2012 at 6:00 AM, Albert Astals Cid \
<span dir="ltr"><<a href="mailto:aacid@kde.org" \
target="_blank">aacid@kde.org</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> El Dimecres, 7 de novembre de 2012, a les 05:51:45, Vishesh \
Handa va escriure:<br> <div class="im">> On Wed, Nov 7, 2012 at 5:36 AM, Albert \
Astals Cid <<a href="mailto:aacid@kde.org">aacid@kde.org</a>> wrote:<br> > \
> El Dimarts, 6 de novembre de 2012, a les 18:30:27, Albert Astals Cid va<br> > \
><br> > > escriure:<br>
> > > El Dimarts, 6 de novembre de 2012, a les 18:17:29, Vishesh Handa \
va<br> > ><br>
> > escriure:<br>
> > > > Ping?<br>
> > > ><br>
> > > > I'll be merging this on Thursday. I would appreciate it if \
somone<br> > > > > could<br>
> > > > review the code.<br>
> > ><br>
> > > I'll have a look later today (based on my 0 knowledge of nepomuk \
&<br> > ><br>
> > friends).<br>
> ><br>
> > Had a look to the code and to my knowledge it seems that it does not do<br>
> > any<br>
> > ultra silly thing, also it's a kioslave so people won't use it \
unless they<br> > > want so in case it is horribly broken the "bad \
stuff" it can do it is<br> > > pretty<br>
> > limited (just don't use the kioslave and done!)<br>
> ><br>
> > So i'd say go ahead.<br>
> ><br>
> > I'm curious with what you mean with "loosing" in "You \
can move files into<br> > > a<br>
> > tag folder thereby effectively loosing them" though. Could you give \
some<br> > > more<br>
> > info?<br>
><br>
> The file will be deleted.<br>
<br>
</div>Ok, that's bad, i'm vetoing on that then. Deleting user files is the \
worst<br> thing ever, even if it is in a "exotic" \
kioslave.<br></blockquote><div><br>Couldn't I still merge it and then work on the \
bug fix before it is officially released?<br> <br></div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div class="im"><br>
> From what I understand KIO does moves by copy +<br>
> delete.<br>
<br>
</div>That's not true, try moving a 4GB file to from a folder to another in the \
file:/<br> kioslave and you see that it actually "moves" the file, not \
copies and deletes<br> it (basically the operation is instantaneous instead of taking \
ages)<br></blockquote><div><br>I think the behaviour I described is across two \
different kio slaves. <br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im"><br>
> The copy operation results in the corresponding tags being applied,<br>
> and the delete operation then deletes the file. The correct behaviour in<br>
> our case would be to either only allow copy operations or convert move<br>
> operations into copy operations.<br>
<br>
</div>Why does the tags: kioslave even knows how to delete files? What's the \
point of<br> it? If i am using the tags: kioslave i would understand i'm just \
working on<br> tags and not on file content.<br></blockquote><div><br>The tags \
kioslave doesn't delete the file. It's the "file" kioslave that \
deletes it.<br><br>Deleting a file from the tags kioslave results in that tag being \
removed.<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"> <br>
Cheers,<br>
Albert<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
> We'll need to introduce some new kio flags to fix this. At least \
that's<br> > what I understood from my discussion with David.<br>
><br>
> > Cheers,<br>
> ><br>
> > Albert<br>
> ><br>
> > > Cheers,<br>
> > ><br>
> > > Albert<br>
> > ><br>
> > > P.S: You sent the email to the wrong list, we do reviews in<br>
> ><br>
> > kde-core-devel<br>
> ><br>
> > > not kde-devel<br>
> > ><br>
> > > > On Wed, Oct 31, 2012 at 3:12 AM, Vishesh Handa <<a \
href="mailto:me@vhanda.in">me@vhanda.in</a>> wrote:<br> > > > > > \
Hey everyone<br> > > > > ><br>
> > > > > I recently wrote a 'tags' kio slave, which allows \
one to browse<br> > ><br>
> > nepomuk<br>
> ><br>
> > > > > tags, and the files containing those tags. It is currently \
in<br> > > > > > kde-runtime/nepomuk/kioslaves/tags/, in the \
nepomuk/tagsKioSlave<br> > ><br>
> > branch.<br>
> ><br>
> > > > > Could someone please review it? I would like to merge it \
before the<br> > ><br>
> > hard<br>
> ><br>
> > > > > freeze.<br>
> > > > ><br>
> > > > > It has a custom url naming scheme -<br>
> > > > ><br>
> > > > > *tags:/tag1* => All the files tagged with 'tag1' \
and additional tags<br> > > > > > which can be used filter the \
results.<br> > > > > ><br>
> > > > > *tags:/tag1/file_url_of_the_file* => This is the url of \
the file.<br> > > > > > Ideally<br>
> > > > > I would just use the normal url of the file, but we need to \
have the<br> > > > > > 'tags'<br>
> > > > > protocol, so that we can handle delete events. We don't \
want to<br> > ><br>
> > delete<br>
> ><br>
> > > > > the<br>
> > > > > file, rather just remove that tag.<br>
> > > > ><br>
> > > > > This file_url_of_the_file is added as the UDS_NAME, and \
results in<br> > ><br>
> > the<br>
> ><br>
> > > > > search results looking slightly ugly if the file properties \
are<br> > ><br>
> > checked.<br>
> ><br>
> > > > > Is<br>
> > > > > there a better way of handling this?<br>
> > > > ><br>
> > > > > *tags:/tag1/tag2 *=> Files tagged with both tag1 and \
tag2<br> > > > > ><br>
> > > > > Known problems -<br>
> > > > > * You can move files into a tag folder thereby effectively \
loosing<br> > ><br>
> > them<br>
> ><br>
> > > > > * No automatic updates<br>
> > > > > * It shows the tags with the nepomuk icon. We need a better \
'tags'<br> > ><br>
> > icon.<br>
> ><br>
> > > > > --<br>
> > > > > Vishesh Handa<br>
> > > >><br>
> > > >> Visit <a \
href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub" \
target="_blank">http://mail.kde.org/mailman/listinfo/kde-devel#unsub</a> to<br> > \
><br> > > unsubscribe<br>
> ><br>
> > > >> <<<br>
> > >><br>
> > >> Visit <a \
href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub" \
target="_blank">http://mail.kde.org/mailman/listinfo/kde-devel#unsub</a> to<br> > \
><br> > > unsubscribe <<<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><span \
style="color:rgb(192,192,192)">Vishesh Handa</span><br><br>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic