[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Nepomuk Tags kioslave - Please Review
From:       David Edmundson <david () davidedmundson ! co ! uk>
Date:       2012-11-07 0:27:45
Message-ID: CAGeFrHDm5fco4Q7wBbcm4Zt5dJY6UiC2dds0SK6fu_9L_CuVQg () mail ! gmail ! com
[Download RAW message or body]

Your .protocol file is missing "Description" parameter

(I'm not entirely sure where actually shows it anymore, I seem to
remember kinfocenter used to.. but it's part of the other protocol
files, so it's something that could be legitimately brought back and
shown)

kio_tags.cpp:

Incredibly minor point:

QLatin1String("/")
should be
QLatin1Char('/')


Bugs from testing:

--

Tags with spaces appear with %20 in the name, as though it's using
url->toString() not url->prettyUrl()

(I won't guess at the nepomuk code here)

--

Tags with "/" in the name break everything, perhaps this can be
escaped in the name (not display name)

--

If you're inside
tags:///Tag1/

it will show a list of files, and other tags.

and you try and rename a _tag_ inside this directory, you will get a crash.


On Tue, Nov 6, 2012 at 9:47 PM, Vishesh Handa <me@vhanda.in> wrote:
> Ping?
>
> I'll be merging this on Thursday. I would appreciate it if somone could
> review the code.
>
>
> On Wed, Oct 31, 2012 at 3:12 AM, Vishesh Handa <me@vhanda.in> wrote:
>>
>> Hey everyone
>>
>> I recently wrote a 'tags' kio slave, which allows one to browse nepomuk
>> tags, and the files containing those tags. It is currently in
>> kde-runtime/nepomuk/kioslaves/tags/, in the nepomuk/tagsKioSlave branch.
>> Could someone please review it? I would like to merge it before the hard
>> freeze.
>>
>> It has a custom url naming scheme -
>>
>> tags:/tag1 => All the files tagged with 'tag1' and additional tags which
>> can be used filter the results.
>>
>> tags:/tag1/file_url_of_the_file => This is the url of the file. Ideally I
>> would just use the normal url of the file, but we need to have the 'tags'
>> protocol, so that we can handle delete events. We don't want to delete the
>> file, rather just remove that tag.
>>
>> This file_url_of_the_file is added as the UDS_NAME, and results in the
>> search results looking slightly ugly if the file properties are checked. Is
>> there a better way of handling this?
>>
>> tags:/tag1/tag2 => Files tagged with both tag1 and tag2
>>
>> Known problems -
>> * You can move files into a tag folder thereby effectively loosing them
>> * No automatic updates
>> * It shows the tags with the nepomuk icon. We need a better 'tags' icon.
>>
>>
>> --
>> Vishesh Handa
>>
>
>
>
> --
> Vishesh Handa
>
>
>
>>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
>>> <<
>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]