[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: KPushButton::setIcon(QIcon) broken?
From:       Andreas Pakulat <apaku () gmx ! de>
Date:       2012-08-23 6:17:15
Message-ID: CAExHGmQY1Ss4hjUdrpWaOiwuiYM5oxCjWsq92Xp258SGvFWtZA () mail ! gmail ! com
[Download RAW message or body]

Hi,

On Thu, Aug 23, 2012 at 3:35 AM, Christoph Feck <christoph@maxiom.de> wrote:
> On Wednesday 22 August 2012 22:28:48 Albert Astals Cid wrote:
>> El Dimecres, 22 d'agost de 2012, a les 02:16:50, Christoph Feck va
> escriure:
>> > On Wednesday 22 August 2012 00:54:12 Andreas Pakulat wrote:
>> > > // This doesn't work
>> > > KPushButton btn;
>> > > btn.setIcon(QIcon::fromTheme(QString::fromUtf8("list-add")));
>> > >
>> > > // This does work, but is not generated by designer obviously
>> > > KPushButton btn;
>> > > btn.setIcon(KIcon(QIcon::fromTheme(QString::fromUtf8("list-add"
>> > > ))))
>> >
>> > To me, it looks like a bug in kdelibs. The method accepting the
>> > QIcon should probably call the other method, instead of only
>> > setting the icon internally in the KGuiItem:
>> >
>> > void KPushButton::setIcon( const QIcon &qicon )
>> > {
>> > -    d->item.setIcon(KIcon(qicon));
>> > +    setIcon(KIcon(qicon));
>> > }
>>
>> Agreed, so are you patching it?
>>
>
> Done. Thanks for the mini-review ;)

Thanks for the quick fix.

Andreas

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]