[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Settings store for custom icons for toolbar
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2012-07-15 17:49:54
Message-ID: 1980402.IHq53kVWQ7 () xps
[Download RAW message or body]

El Diumenge, 15 de juliol de 2012, a les 19:43:07, Daniel Kreuter va escriure:
> On Tuesday, July 10, 2012 10:32:47 PM Albert Astals Cid wrote:
> > El Dimarts, 10 de juliol de 2012, a les 21:31:46, Daniel Kreuter va
> 
> escriure:
> > > Hey guys,
> > > 
> > > Using the settings menu you are able to add new actions to the toolbar,
> > > and
> > > even set icons for it. Where does KDE store these information?
> > 
> > In .kde/share/apps/APPNAME/UIFILE.rc (if dolphin uses xmlgui)
> > 
> > > I'm investigation https://bugs.kde.org/show_bug.cgi?id=255819.
> > > Since I'm quite new to KDE development I don't find the right place
> > > where
> > > I
> > > can start to debug to find out why dolphin doesn't save the icon set by
> > > the
> > > user for this item.
> > > This only seems to happen for the sort by action, but i only tried the
> > > additional information action yet (will have to try each possibility
> > > later
> > > to make sure that this bug doesn't apply elsewhere as well).
> > > 
> > > Any ideas where I can start my search?
> > > I just found out where the action is defined, but I don't know exactly
> > > where the data gets stored for these actions.
> > 
> > Not really, this is xmlgui stuff (well, taht's assuming dolphin didn't
> > reinvent the wheel) that is a bit tricky to debug, but really interesting
> > to learn, so do not give up!
> 
> Dolphin has a class named DolphinViewActionHandler which defines, which
> actions exist.
> But as you said the xml stuff is done in xmlgui, so this will be the reason
> why I can't find the part where it gets loaded.
> Maybe we should file the bug report against kdelibs instead of dolphin?

Maybe, maybe not, if i do the same (add action to toolbar and set icon) in 
Okular it works fine.

Of course it can still be an kdelibs bug or a Dolphin bug.

Anyway, don't think that if you file a bug report against kdelibs it will be 
automagically fixed by a host of kdelibs bugfixers, so in my opinion, you have 
gathered already some knowledge of the bug itself, don't let the fact that the 
bug might be in kdelibs instead of dolphin stop you, open kdelibs code and try 
to fix it there!

Cheers,
  Albert

> 
> Greetings
> 
> Daniel
> 
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
> >> <<

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]