[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: KSlideshow: EXIF orientation in images is not honored
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2010-09-23 20:55:33
Message-ID: 201009232155.34407.aacid () kde ! org
[Download RAW message or body]

A Dijous, 23 de setembre de 2010, Anne-Marie Mahfouf va escriure:
> Hi Guillaume, hi all,
> 
> Thanks for the patch. I tested it and changed a bit the way KEXIV2 is
> found, based on what is done for the applet Picture Frame.
> It works well! As I had a new fresh build I tested first without libxeviv2
> then with it.
> 
> Albert, can I commit or should I put the patch on kdereview (but there's no
> active devel for this slideshow screensaver I think)

I think the code is straightforward enough that you can commit it. Please note 
than the macro_log_feature is not totally correct as, as far as i remeber, 
Kexiv2 is in kdegraphics and not kdesupport

Albert

> 
> Best regards,
> 
> Anne-Marie
> 
> On Wednesday 22 September 2010 21:34:33 Guillaume Benny wrote:
> > On Wednesday September 22 2010 13:48:58 Albert Astals Cid wrote:
> > > A Dimecres, 22 de setembre de 2010, Guillaume Benny va escriure:
> > > > > >  https://bugs.kde.org/show_bug.cgi?id=231599
> > > >  
> > > >  Thanks for your answer. I don't know how you wanted the patch and
> > > >  since I
> > > > 
> > > > don't have a KDE developper's environnement, I did the best I could!
> > > > 
> > > > :-)
> > > 
> > > What do you mean "you don't have a KDE developer environment"? You mean
> > > you have blind coded (i.e. not even checked they compile) the patches?
> > > 
> > > Albert
> >  
> >  Hi,
> >  
> >  To clarify: I'm using Gentoo Linux so all the programs on my computer,
> > 
> > including KDE, are compiled from source. So I do have everything I need
> > to compile and test this patch (which I did: I do mention that in the
> > bug report). But I'm running a 'stable' Gentoo so I don't have the
> > latest sources. So my tests where on KDE 4.4.4 and 4.4.5 and not on the
> > latest git or svn repository. But the patch should apply directly to the
> > latest repository since the source is almost identical.
> > 
> >  That's what I wanted to say when I wrote that I don't have a developer's
> > 
> > environment.
> > 
> >  Hope this all made sense!
> >  
> >  Guillaume
> >  
> > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> > >> unsubscribe <<
> >> 
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> >> unsubscribe <<
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]