[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] What's this texts and label change for Input Actions
From:       Jesse Janhonen <jesse.janhonen () gmail ! com>
Date:       2010-06-06 18:15:07
Message-ID: AANLkTilS3A6Opfst1Tm2zyS8imey4jXY6JFTd7nlP6AN () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


I'll use reviewboard for now, most likely only few patches to come this
summer.

On 6 June 2010 19:07, Michael Jansen <kde@michael-jansen.biz> wrote:

> On Samstag 05 Juni 2010 16:18:24 Jesse Janhonen wrote:
> > Hello
> >
> > This my first ever patch to anything adds some what's this texts into
> > Settings dialog of Input Actions and changes one check box label to more
> > descriptive one.
> >
> > Target:
> >
> trunk/KDE/kdebase/workspace/khotkeys/kcm_hotkeys/global_settings_widget.ui
> >
> > I'm planning to patch more online help, maybe handbook and maybe even
> some
> > adjustments to the Actions -settings gui as a learning experience. So
> would
> > this be the appropriate place to send the patches or what? It's
> > documentation but changes program sources. I targeted a week ago author
> > Michael Jansen but no answer.
>
> Because you failed to get by my spam filter. Sorry. I whitelisted your
> address now.
>
> I'm one of the more relaxed devs here regarding patches to code i am
> considered maintainer. More so
> when it touches documentation, handbook and everything english language.
>  I'm no native speaker and
> even fail to formulate valid sentences in my mother language most of the
> time.
>
> Therefore i normally would say get a subversion account and commit the
> changes directly. i review
> any commit there anyway. If i see something worth commenting i will do it
> after you committed. If
> you commit something more complicated or something you are unsure of cc me
> with the commit just to
> be sure and show me you want feedback.
>
> Not every maintainer btw is ok with someone else commiting stuff to his
> code without contacting him
> before doing it.
>
>
> Mike
>
>

[Attachment #5 (text/html)]

I&#39;ll use reviewboard for now, most likely only few patches to come this summer. \
<br><br><div class="gmail_quote">On 6 June 2010 19:07, Michael Jansen <span \
dir="ltr">&lt;<a href="mailto:kde@michael-jansen.biz">kde@michael-jansen.biz</a>&gt;</span> \
wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;"><div class="im">On Samstag 05 Juni 2010 16:18:24 Jesse \
Janhonen wrote:<br> &gt; Hello<br>
&gt;<br>
&gt; This my first ever patch to anything adds some what&#39;s this texts into<br>
&gt; Settings dialog of Input Actions and changes one check box label to more<br>
&gt; descriptive one.<br>
&gt;<br>
&gt; Target:<br>
&gt; trunk/KDE/kdebase/workspace/khotkeys/kcm_hotkeys/global_settings_widget.ui<br>
&gt;<br>
&gt; I&#39;m planning to patch more online help, maybe handbook and maybe even \
some<br> &gt; adjustments to the Actions -settings gui as a learning experience. So \
would<br> &gt; this be the appropriate place to send the patches or what? \
It&#39;s<br> &gt; documentation but changes program sources. I targeted a week ago \
author<br> &gt; Michael Jansen but no answer.<br>
<br>
</div>Because you failed to get by my spam filter. Sorry. I whitelisted your address \
now.<br> <br>
I&#39;m one of the more relaxed devs here regarding patches to code i am considered \
maintainer. More so<br> when it touches documentation, handbook and everything \
english language.  I&#39;m no native speaker and<br> even fail to formulate valid \
sentences in my mother language most of the time.<br> <br>
Therefore i normally would say get a subversion account and commit the changes \
directly. i review<br> any commit there anyway. If i see something worth commenting i \
will do it after you committed. If<br> you commit something more complicated or \
something you are unsure of cc me with the commit just to<br> be sure and show me you \
want feedback.<br> <br>
Not every maintainer btw is ok with someone else commiting stuff to his code without \
contacting him<br> before doing it.<br>
<br>
<br>
Mike<br>
<br>
</blockquote></div><br>



>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]