[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    kremotecontrol now in kdeutils - QtXmlPatterns requirement
From:       Jonathan Marten <jjm2 () keelhaul ! demon ! co ! uk>
Date:       2010-04-12 15:58:44
Message-ID: ovaat8ek7f.fsf () keelhaul ! local
[Download RAW message or body]

To Michael Zanetti (as author/maintainer of kremotecontrol)...

With this in trunk, the QtXmlPatterns module is now required in order
to build kdeutils:

In file included from \
                /ws/trunk/kdeutils/kremotecontrol/libkremotecontrol/profileaction.cpp:21:
                
/ws/trunk/kdeutils/kremotecontrol/libkremotecontrol/profileserver.h:29:49: error: \
                QtXmlPatterns/QAbstractMessageHandler: No such file or directory
/ws/trunk/kdeutils/kremotecontrol/libkremotecontrol/profileserver.h:30:36: error: \
QtXmlPatterns/QXmlSchema: No such file or directory [and more errors as a result]

Unfortunately, to include QtXmlPatterns Qt needs to be built with
exception support, which is not available on all platforms and
compilers and which as far as I know is not a requirement for any
other part of KDE.  In order to not have exceptions as a hard
dependency, would it be OK to make the build of kremotecontrol
conditional, in the top level CMakeLists.txt as follows?

--- ../CMakeLists.txt   (revision 1113961)
+++ ../CMakeLists.txt   (working copy)
@@ -26,6 +26,7 @@
 macro_log_feature( GMP_FOUND "GMP" "The GNU Multiple Precision Arithmetic Library" \
"http://gmplib.org/" FALSE "" "Required for building KCalc.")  \
macro_optional_find_package( QCA2 )  macro_log_feature( QCA2_FOUND "QCA2" "Qt \
Cryptographic Architecture" "http://delta.affinix.com/qca" FALSE "2.0.0" "Needed for \
most of the algorithms of the checksum tool in Okteta." ) +macro_log_feature( \
QT_QTXMLPATTERNS_FOUND "QtXmlPatterns" "Qt support for XPath, XQuery, XSLT and XML \
Schema validation" "http://doc.trolltech.com/latest/qtxmlpatterns.html" FALSE "" \
"Required to build kremotecontrol." )  
 # --- programs ---
 # listed alphabetically, each with own guards
@@ -36,7 +37,9 @@
 if( UNIX )
     find_package(KDE4Workspace)
     if(KDE4Workspace_FOUND)
-        macro_optional_add_subdirectory( kremotecontrol )
+        if(QT_QTXMLPATTERNS_FOUND)
+            macro_optional_add_subdirectory( kremotecontrol )
+        endif(QT_QTXMLPATTERNS_FOUND)
     endif(KDE4Workspace_FOUND)
     macro_optional_add_subdirectory( kdf )
     # K3Process

The user will get some explanation if support is not available.

Regards
  Jonathan

-- 
Jonathan Marten                         http://www.keelhaul.demon.co.uk
Twickenham, UK                          jjm2@keelhaul.demon.co.uk
 
> > Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]