[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] powerdevil-fix-SetPowerSave.patch
From:       Kevin Ottens <ervin () kde ! org>
Date:       2010-03-30 18:03:23
Message-ID: 201003302003.34095.ervin () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Wednesday 24 March 2010 16:26:06 Dario Freddi wrote:
> I would wait for Kevin's input/ok for this one. Ok for me, but please wait
> until Kevin says ok as well.

OK to go.

Note that as I see libsolidcontrol life reaching its end anyway I'm less picky 
(otherwise I'd probably complain about the lack of signal upon property 
change). ;-)
 
> On Wednesday 24 March 2010 16:24:46 Holger Macht wrote:
> > On So 07. Mär - 23:57:52, Holger Macht wrote:
> > > Current powerdevil and solid implementation has the concept of schemes,
> > > not to be confused with profiles, which is currently hard coded to
> > > "powersave" and "performance". The only thing this is doing is to map
> > > powersave/performance to the SetPowerSave HAL method which either
> > > enabled or disables certain system level power management
> > > functionality. I have no idea why this was implemented in this way and
> > > lacks any basis for me.

Of all people I would have expected you to be the one to know the basis for 
it. It was written at a time where powersaved was still alive and kicking, and 
providing much better feature set than HAL in the power management area (still 
does IMHO). Since powersaved had its own schemes and we had to be able      to 
run on top of HAL or powersaved, a simple boolean wasn't enough.

Hope that explains. Am I wrong thinking you were previously working on 
powersaved?

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud patron of KDE, http://www.kdab.com

["signature.asc" (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]