[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] powerdevil-remove-cpufreq.patch
From:       Holger Macht <holger () homac ! de>
Date:       2010-03-08 0:12:26
Message-ID: 4B9440EA.4020204 () homac ! de
[Download RAW message or body]

On 03/08/2010 12:28 AM, Dario Freddi wrote:
> Hi Holger,
> 
> thank you for this set of patches. Before I go on reviewing them (there are 
> some parts that I like and some parts that I actually don't) I would 
> appreciate if you could post them on our reviewboard - 
> http://reviewboard.kde.org to ease their reviewal. Reviewboard is the place 
> where we usually collect and review all patches to KDE svn.

Sure, I will.

Thanks,
 Holger

> 
> On Sunday 07 March 2010 23:57:37 Holger Macht wrote:
>> Remove all CPU frequency scaling code from powerdevil and the kcm
>> module. You should never offer those options to the user because he
>> might not understand what the impact is. You only want a dynamic
>> frequency algorithm which is the default these days (ondemand
>> governor). A good explanation is provided in [1].
>>
>> Regards,
>>  Holger
> 

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]