[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request: Fix solid brightness control initialization
From:       Andreas Hartmetz <ahartmetz () gmail ! com>
Date:       2009-12-15 12:55:27
Message-ID: 200912151355.27911.ahartmetz () gmail ! com
[Download RAW message or body]

On Tuesday 15 December 2009 00:06:56 Sebastian Kügler wrote:
> On Monday 14 December 2009 16:58:53 Nate Weibley wrote:
> > Sebastian:
> > I don't have an SVN account. If I remain active working on KDE bugs I'll
> > apply for one later.
> >
> > Thanks for committing for me.
> 
> Confirmed working and committed as r1062504, thanks!
> 
> > ---Nate
> >
> > On Mon, Dec 14, 2009 at 7:05 AM, Sebastian Kügler <sebas@kde.org> wrote:
> > > On Sunday 13 December 2009 16:05:57 nweibley@gmail.com wrote:
> > > > http://reviewboard.kde.org/r/2368/
> > > >
> > > > Fixes implicit typecast from previous commit to halpower.cpp and
> > >
> > > addresses
> > >
> > > >  a new bug precipitated by hal-0.5.14 in which the battery plasmoid
> > > >  unconditionally reset screen brightness to 0
> > > >
> > > >
> > > > This addresses bugs 196232 and 217316.
> > > >     https://bugs.kde.org/show_bug.cgi?id=196232
> > > >     https://bugs.kde.org/show_bug.cgi?id=217316
> > > >
> > > > Diff: http://reviewboard.kde.org/r/2368/diff
> > > >
> > > > Tested against hal-0.5.13 and hal-0.5.14 on Gentoo X86_64, kernel
> > > > 2.6.32, kde-4.3.4, qt-4.6.
> > >
> > > Nice. Do you have an SVN account? If not, I can commit it for you.
> > >
> > > Thanks for looking into it and providing a patch!
> 

The type thing looked fishy to me when I fixed something unrelated in the same 
source file. Of course I didn't expect that it was actually wrong...
Also, please don't top-post.
A: Because it destroys the flow of conversation.
Q: Why is top-posting bad?

Cheers,
Andreas
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]