[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: kdeplasma-addons fifteenpuzzle patch
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2009-09-16 16:31:18
Message-ID: 200909161031.19085.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On September 15, 2009, Tomaz Canabrava wrote:
> Patch for fifteen puzzle:

cool; some comments:

* "changeFoo" methods should be "setFoo"

* "getFoo" methods should just "foo()"

* m_level -> m_dimensions? or m_tilecount, or? level sounds more like what 
happens after you solve the first puzzle, and it's really a board dimension

* once the kconfig is handled, this can probably go into svn. usually 
connecting to the accepted() signal on the passed in dialog works nicely for 
that :)

also, if you can, please post such patches on reviewboard.kde.org and assign 
them to the plasma group. it fits our workflow much better and helps ensure 
your patches do not get lost.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

["signature.asc" (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]