[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: KMainWindow/KAboutData allows invalid names (was:
From:       Thomas =?utf-8?q?L=C3=BCbking?= <thomas.luebking () web ! de>
Date:       2009-08-10 21:15:42
Message-ID: 200908102315.42890.thomas.luebking () web ! de
[Download RAW message or body]

Am Monday 10 August 2009 schrieb Matthew Woehlke:

> I guess appName never shows up anywhere visible to the user?
I don't think so (yes, the translated programName appears to be used as def. 
caption - it's usually translated)

On the one hand i'd say to sanitize this only where necessary, but on the 
other hand sanitizing QCoreApplication::applicationName() ensures that the app 
will internally (if not hardcoded...) not mismatch when e.g. trying to export 
or access this value for dbus usage.

So i'd (slightly) rather handle this in KAboutData (i think this has to be set 
for the major and almost only used KApplication c'tor anyway) and drop the 
check in KMainWindow - but feel quite out of pos to decide this ;-)

Thomas
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]