[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] FindEigen2.cmake
From:       Alexander Neundorf <neundorf () kde ! org>
Date:       2009-01-11 15:41:40
Message-ID: 200901111641.40992.neundorf () kde ! org
[Download RAW message or body]

On Sunday 11 January 2009, James Richard Tyrer wrote:
> James Richard Tyrer wrote:
> > I find that KOffice won't build on my system because it finds the wrong
> > version of Eigen2.
>
> OK, after a different FindEigen.cmake file was committed to KOffice,
> filing a bug report with CMake and being told that we have the code
> wrong, I believe that this patch is correct:
>
> ------8<------8<------8<------8<------8<------8<------8<------8<------
>
> Index: FindEigen2.cmake
> ===================================================================
> --- FindEigen2.cmake    (revision 909224)
> +++ FindEigen2.cmake    (working copy)
> @@ -16,10 +16,10 @@ if (EIGEN2_INCLUDE_DIR)
>   else (EIGEN2_INCLUDE_DIR)
>
>   find_path(EIGEN2_INCLUDE_DIR NAMES Eigen/Core
> -     PATHS
> +     PATH_SUFFIXES eigen2
> +     HINTS
>        ${INCLUDE_INSTALL_DIR}
>        ${KDE4_INCLUDE_DIR}
> -     PATH_SUFFIXES eigen2
>      )
>
>   include(FindPackageHandleStandardArgs)
>
> ------8<------8<------8<------8<------8<------8<------8<------8<------
>
> and will do what we thought that the current code would do.  It appears
> that the bug was in our understanding of what the options would do. :-)
>
> It appears to me that this should be committed to:
>
> 	trunk/kdesupport/eigen2/bench/btl/cmake
> 	trunk/koffice/cmake/modules
> 	trunk/KDE/kdelibs/cmake/modules
>
> Is this OK to commit?  

Looks good, please go ahead :-)

Alex
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]