From kde-devel Mon Oct 20 22:28:05 2008 From: Michael Howell Date: Mon, 20 Oct 2008 22:28:05 +0000 To: kde-devel Subject: Re: [PATCH] Re: resurrecting kwrited Message-Id: <200810201528.11028.mhowell123 () gmail ! com> X-MARC-Message: https://marc.info/?l=kde-devel&m=122454177011647 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1967201641==" --===============1967201641== Content-Type: multipart/signed; boundary="nextPart2265234.5Uof1GqEaQ"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit --nextPart2265234.5Uof1GqEaQ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Monday 20 October 2008 01:30:34 Oswald Buddenhagen=20 wrote: > On Sat, Oct 18, 2008 at 01:12:56PM +0300, George=20 Kiagiadakis wrote: > > 2008/10/17, Oswald Buddenhagen : > > > you are the kwrited maintainer now. get > > > yourself an svn account to fulfill that role. :D > > > > Are you sure that would be the right thing to do? > > sure. :D > > > Anyway, I am sending the full patch against kdebase for=20 last minute > > review. If anyone has any objections, tell me. > > the utempter test is duplicated, which is just ugly. > > i think the entire kwrited should be factored out from=20 konsole - it is > there only for historical reasons. probably it should be=20 kicked from > kdebase and moved to kdeutils or so. Personally, I vote kdebase/workspace, since it's part of the=20 desktop experience and doesn't really count as a utility. > > > 1) The kwrited executable (if built as an executable) is=20 setgid to the > > utmp group. I am not sure if all distros that do not ship=20 libutempter > > use this group for /var/run/utmp and /var/log/wtmp. At=20 least debian > > does. > > given that debian (+ derivatives) is probably the only distri=20 not > shipping utempter ... :D > anyway, i think this group is fairly standard. if not, then=20 somebody > will have to introduce a check and a variable to make it=20 work on his > system. > > > 2) This commit introduces a new .desktop file > > (kwrited-noutempter.desktop). As this is a modified copy=20 of the > > already existing kwrited.desktop, it already includes the=20 translated > > strings. Is that ok? > > i think so. > > > Also, I am unsure if the commands in that desktop > > file are correct (although they do work for me). This=20 desktop file is > > supposed to be installed in ${AUTOSTART_INSTALL_DIR}=20 to start kwrited > > by default on startup. The commands are somehow=20 based on > > ${AUTOSTART_INSTALL_DIR}/krunner.desktop > > uhm ... no idea. does it work? :D =2D-=20 Michael Howell mhowell123@gmail.com --nextPart2265234.5Uof1GqEaQ Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBI/QX6NA5YrRD1JsMRAijMAJ9hMjQQeLB3GFgCxktHoshNj0oefQCgiCCp g8peeMlTkx04n3xsHL5j8lU= =crXN -----END PGP SIGNATURE----- --nextPart2265234.5Uof1GqEaQ-- --===============1967201641== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============1967201641==--