[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] Re: resurrecting kwrited
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2008-10-20 8:30:34
Message-ID: 20081020083034.GA21356 () troll08
[Download RAW message or body]

On Sat, Oct 18, 2008 at 01:12:56PM +0300, George Kiagiadakis wrote:
> 2008/10/17, Oswald Buddenhagen <ossi@kde.org>:
> > you are the kwrited maintainer now. get
> >  yourself an svn account to fulfill that role. :D
> 
> Are you sure that would be the right thing to do?
>
sure. :D

> Anyway, I am sending the full patch against kdebase for last minute
> review. If anyone has any objections, tell me.
>
the utempter test is duplicated, which is just ugly.

i think the entire kwrited should be factored out from konsole - it is
there only for historical reasons. probably it should be kicked from
kdebase and moved to kdeutils or so.

> 1) The kwrited executable (if built as an executable) is setgid to the
> utmp group. I am not sure if all distros that do not ship libutempter
> use this group for /var/run/utmp and /var/log/wtmp. At least debian
> does.
> 
given that debian (+ derivatives) is probably the only distri not
shipping utempter ... :D
anyway, i think this group is fairly standard. if not, then somebody
will have to introduce a check and a variable to make it work on his
system.

> 2) This commit introduces a new .desktop file
> (kwrited-noutempter.desktop). As this is a modified copy of the
> already existing kwrited.desktop, it already includes the translated
> strings. Is that ok?
>
i think so.

> Also, I am unsure if the commands in that desktop
> file are correct (although they do work for me). This desktop file is
> supposed to be installed in ${AUTOSTART_INSTALL_DIR} to start kwrited
> by default on startup. The commands are somehow based on
> ${AUTOSTART_INSTALL_DIR}/krunner.desktop
> 
uhm ... no idea. does it work? :D

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Confusion, chaos, panic - my work here is done.
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]