[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [Fixed] Re: kdeplasma-addons does not build (boost related)
From:       Andreas Pakulat <apaku () gmx ! de>
Date:       2008-08-04 20:48:52
Message-ID: 20080804204848.GA19432 () morpheus ! apaku ! dnsalias ! org
[Download RAW message or body]

On 04.08.08 21:14:15, Stephan Johach wrote:
> Am Montag 04 August 2008, 19:58:26 schrieb Andreas Pakulat:
> > Then I'm at loss right now why its not found. You could try to debug
> > this yourself by adding message() calls in FindBoost.cmake and check the
> > variables, especially what happens during the two loops that try to find
> > the right include dir (line 269 and following)
> 
> You were talking about trunk i guess.

Yes, I don't have 4.1 here.

> In 4.1 branch there's no
> find_package(Boost) in CMakeLists.txt. I added it here, but it failed.
> Adding the Boost_INCLUDE_DIR eventually fixed it for me.

Please look at the trunk version. The osnews stuff needs to be inside
an if(Boost_FOUND) and inside that should also be the
include_directories call. Seems like too few people build release
tarballs with systems where boost is not available as
/usr/include/boost/*hpp

After the modifications this should be comitted to 4.1 branch - or find
the revision that changed trunk/ and just backport it via svn merge. Or
tell plasma-devel list if you don't have commit rights.

> Patch attached. I wonder why it works in trunk for other people?

Because trunk's kdeplasma-addons has the needed find_package and
include_directories calls.

Actually the problem is that kdepimlibs exposes the Boost stuff in its
public API. Thats bad, at least without requiring Boost in
FindKdepimibs. I'll raise that on our buildsyste list.

Andreas

-- 
You will hear good news from one you thought unfriendly to you.
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]