[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Patch for krdc trunk
From:       Urs Wolfer <uwolfer () kde ! org>
Date:       2008-08-02 9:18:36
Message-ID: 200808021118.36583.uwolfer () kde ! org
[Download RAW message or body]

On Saturday 02 August 2008 04:31:12 Guillaume Pothier wrote:
> Hi,
> I've recently filed a bug (http://bugs.kde.org/show_bug.cgi?id=168015)
> about keyboard handling in krdc. As this problem was actually
> preventing me from getting work done, I had a try at fixing it. So it
> works perfectly for me now. I also made dead keys work properly.
>
> I think I have tested the patch quite thoroughly, although only with a
> spanish keyboard. So here comes the patch, I hope it is useful. As it
> is the first time I submit a patch, please tell me if something is
> wrong, or if there is something special to do to have it applied.

Hi

Thank you a lot for the patch! It seems to fix the issue. I will apply it to 
trunk and KDE 4.1 stable later.

Also bug #162865 seems to be fixed (the KDE 4 releated comments).

One comment: bool isLetter = isLower || isUpper; is unused?!

Btw, it's also possible to attach patches to bug reports ;)

Bye
urs
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]