[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Kicker patches (was Patches and enhancements for KDE 3.5)
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2008-07-24 17:03:36
Message-ID: 200807241103.36458.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thursday 24 July 2008, Benoit Minisini wrote:
> I continued on fixing kicker transparency, and many other problems. Where
> should I submit my patches? I think the kicker mailing-list is deprecated,

there never was a kicker maling list. there were never more than 2 people 
working on things, usually just one. makes a mailing list useless ;)

> and I don't think I should put them on the plasma mailing-list.

probably not.

> - I added a SimpleArrowButton class and used it to replace many arrow

added where? and what does it look like? perhaps you can upload your patches 
somewhere and then post links to them here.

> - I used SimpleButton in the launcher and in the weather applet, so that
> their buttons look the same as panel buttons. It allowed me to remove
> duplicated code from the launcher applet.

i assume by "used SimpleButton" you mean you copied the file over to these 
applets? weather applet didn't live in kdebase...

> - I fixed the ContainerArea and taskbar transparency background when they
> are scrollable. To do that, I used 'setBackgroundOrigin(WindowOrigin)'.
>
> - By using WindowOrigin, I didn't need to duplicate pieces of the
> ContainerArea background pixmap in each applet anymore.

i doubt this will actually work in all cases. i don't remember exactly which 
situations that i ran into with this approach, but i didn't go through all 
that work just because i liked writing more code. at one point i was setting 
the background origin everywhere, but it would fail rather annoyingly at times 
(perhaps certain configurations? hrm.. i really can't remember)

> - I removed the one pixel border when kicker has a background image. (Why a
> border in that specific case?)

because not all kicker wallpapers have a defined edge and relied on that one 
pixel. i removed it at one point and it broke many wallpapers visually. so it 
remained for compatibility. it should not be removed for that reason. no, it's 
not great, but there it is.

> - I removed the useless margin around applet handlers.

useless except to provide some whitespace when shown. probably makes quite a 
difference when they are set to always be visible (as they once were). i 
personally wouldn't suggest this change.

> - I wanted that coverable panels stays on the background, even if you click
> on it, but I didn't succeed. I think that the "show desktop" button is
> enough to access this kind of panels. After all, if you allow windows to
> cover them, it should mean that you want the panel to stay in the
> background, no?

no. it just means "let windows cover it as i use it". if you change this 
behaviour, you'll annoy people who are used to and like the current behaviour.

> - I made kicker automatically restart when the KDE widget style change.

that sounds very unusually and really not good.

> Otherwise, many widget layouts become invalid.

in what way?

> - I have problems with the system tray applet transparency yet.

and you probably always will. the systray spec is not designed for 
transparency and it's all a bunch of hacks.

> Well, please tell me which fixes and changes could go in the KDE code.

for the ones i didn't comment on above, it's impossible to say without seeing 
the actual patches.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech


["signature.asc" (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]