[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] frame plasmoid: Switch photo when the user clicks on it
From:       Allen Winter <winter () kde ! org>
Date:       2008-07-04 13:46:57
Message-ID: 200807040946.58279.winter () kde ! org
[Download RAW message or body]

On Friday 04 July 2008 08:39:49 Éric ALBER wrote:
> Hi,
> 
> I wrote a litte patch for the frame plasmoid.
> The idea is that if you click on the photo in the frame, it switches
> immediately to the next photo in slideshow mode
> 
> I have also fixed two compiler warnings (misuse of uint and a missing
> Q_UNUSED).
> 
> I attached the patch to this mail. It applies to
> trunk/KDE/kdeplasmoids/applets/frame/frame.cpp
> trunk/KDE/kdeplasmoids/applets/frame/frame.h
> trunk/KDE/kdeplasmoids/applets/frame/slideshow.cpp
> I created the patch in the kdeplasmoids directory
> 
> I also noticed that void mousePressEvent (QGraphicsSceneMouseEvent *event)
> and other methods are not declared virtual in Plasma/Applet but the same
> methods are virtual in QGraphicsItem. I also noticed that the destructor of
> the Applet class is not virtual either. Is this a design choice or has it
> just been forgotten ?
> 

Éric,

You should probably join the kde-panel mailing list and take
this discussion there.  kde-panel is where the Plasma team discusses
stuff like this.
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]