[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: [PATCH] frame plasmoid: Switch photo when the user clicks on it
From: "=?UTF-8?Q?=C3=89ric_ALBER?=" <eric.alber () gmail ! com>
Date: 2008-07-04 13:32:45
Message-ID: 676e80e0807040632v35560e92n2f72ca0ff35db3fd () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
[Attachment #4 (text/plain)]
Yes, probably, I'll just have to update the Slideshow class to enable
navigation to the previous picture.
I'll do it this WE :)
2008/7/4 John Tapsell <johnflux@gmail.com>:
> If clicking advances it forward to the next image, then shift+click or
> similiar should advance it back again. Would it be easy to add this?
> Thanks!
>
> John Tapsell
>
> 2008/7/4 Éric ALBER <eric.alber@gmail.com>:
> > Hi,
> >
> > I wrote a litte patch for the frame plasmoid.
> > The idea is that if you click on the photo in the frame, it switches
> > immediately to the next photo in slideshow mode
> >
> > I have also fixed two compiler warnings (misuse of uint and a missing
> > Q_UNUSED).
> >
> > I attached the patch to this mail. It applies to
> > trunk/KDE/kdeplasmoids/applets
> > /frame/frame.cpp
> > trunk/KDE/kdeplasmoids/applets/frame/frame.h
> > trunk/KDE/kdeplasmoids/applets/frame/slideshow.cpp
> > I created the patch in the kdeplasmoids directory
> >
> > I also noticed that void mousePressEvent (QGraphicsSceneMouseEvent
> *event)
> > and other methods are not declared virtual in Plasma/Applet but the same
> > methods are virtual in QGraphicsItem. I also noticed that the destructor
> of
> > the Applet class is not virtual either. Is this a design choice or has it
> > just been forgotten ?
> >
> > Regards,
> >
> > Eric
> >
> >>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe
> >>> <<
> >
> >
>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe <<
>
[Attachment #5 (text/html)]
Yes, probably, I'll just have to update the Slideshow class to enable navigation \
to the previous picture.<br>I'll do it this WE :)<br><br><br><div \
class="gmail_quote">2008/7/4 John Tapsell <<a \
href="mailto:johnflux@gmail.com">johnflux@gmail.com</a>>:<br> <blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;">If clicking advances it forward to the next image, \
then shift+click or<br> similiar should advance it back again. Would it be easy \
to add this?<br> Thanks!<br>
<br>
John Tapsell<br>
<br>
2008/7/4 Éric ALBER <<a \
href="mailto:eric.alber@gmail.com">eric.alber@gmail.com</a>>:<br> \
<div><div></div><div class="Wj3C7c">> Hi,<br> ><br>
> I wrote a litte patch for the frame plasmoid.<br>
> The idea is that if you click on the photo in the frame, it switches<br>
> immediately to the next photo in slideshow mode<br>
><br>
> I have also fixed two compiler warnings (misuse of uint and a missing<br>
> Q_UNUSED).<br>
><br>
> I attached the patch to this mail. It applies to<br>
> trunk/KDE/kdeplasmoids/applets<br>
> /frame/frame.cpp<br>
> trunk/KDE/kdeplasmoids/applets/frame/frame.h<br>
> trunk/KDE/kdeplasmoids/applets/frame/slideshow.cpp<br>
> I created the patch in the kdeplasmoids directory<br>
><br>
> I also noticed that void mousePressEvent (QGraphicsSceneMouseEvent *event)<br>
> and other methods are not declared virtual in Plasma/Applet but the same<br>
> methods are virtual in QGraphicsItem. I also noticed that the destructor of<br>
> the Applet class is not virtual either. Is this a design choice or has it<br>
> just been forgotten ?<br>
><br>
> Regards,<br>
><br>
> Eric<br>
><br>
</div></div>>>> Visit <a \
href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub" \
target="_blank">http://mail.kde.org/mailman/listinfo/kde-devel#unsub</a> to \
unsubscribe<br> >>> <<<br>
><br>
><br>
<br>
>> Visit <a href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub" \
target="_blank">http://mail.kde.org/mailman/listinfo/kde-devel#unsub</a> to \
unsubscribe <<<br> </blockquote></div><br>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic