[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: kdelib CMakeFile should check if X11/SM/SMlib.h is available
From: Allen Winter <winter () kde ! org>
Date: 2008-05-20 14:42:53
Message-ID: 200805201042.54511.winter () kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Tuesday 20 May 2008 05:34:59 Esben Mose Hansen wrote:
> Hi,
>
> debian unstable ships said headerfile in libsm-dev, so it might be a good
> idea to check for the header file explicitly in configure, instead of
> having the compile fail with a missing include inside.
We currently don't complain about all the various sub-packages
and extensions within X that might cause build problems.
We look for many (see kdelibs/cmake/modules/FindX11.cmake)
but we don't complain if they aren't there.
I suppose SM and ICE are important enough that we could put something like:
if(NOT X11_ICE_FOUND)
message(FATAL_ERROR "install ICE")
endif(NOT X11_ICE_FOUND)
ditto for SM.
Should I do this?
[Attachment #5 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"> <html><head><meta name="qrichtext" \
content="1" /><style type="text/css"> p, li { white-space: pre-wrap; }
</style></head><body style=" font-family:'Sans Serif'; font-size:10pt; \
font-weight:400; font-style:normal;"> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">On Tuesday 20 May 2008 05:34:59 Esben Mose Hansen wrote:</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> Hi,</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">></p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> debian unstable ships \
said headerfile in libsm-dev, so it might be a good</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">> idea to check for the header file explicitly \
in configure, instead of</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">> having the compile fail with a missing include inside.</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"></p> <p \
style=" margin-top:0px; margin-bottom:12px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">We currently don't complain \
about all the various sub-packages</p> <p style=" margin-top:0px; margin-bottom:12px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">and extensions within X that might cause build problems.</p> <p \
style=" margin-top:0px; margin-bottom:12px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">We look for many (see \
kdelibs/cmake/modules/FindX11.cmake)</p> <p style=" margin-top:0px; \
margin-bottom:12px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">but we don't complain if they aren't there.</p> \
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:12px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"></p> <p style=" margin-top:0px; margin-bottom:12px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">I suppose SM and ICE are important enough that we could put \
something like:</p> <p style=" margin-top:0px; margin-bottom:12px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">if(NOT \
X11_ICE_FOUND)</p> <p style=" margin-top:0px; margin-bottom:12px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"> \
message(FATAL_ERROR "install ICE")</p> <p style=" margin-top:0px; margin-bottom:12px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">endif(NOT X11_ICE_FOUND)</p> <p style=" margin-top:0px; \
margin-bottom:12px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">ditto for SM.</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:12px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"></p> <p \
style=" margin-top:0px; margin-bottom:12px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Should I do this?</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:12px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"></p></body></html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic