From kde-devel Tue Apr 29 17:11:00 2008 From: Dominik Haumann Date: Tue, 29 Apr 2008 17:11:00 +0000 To: kde-devel Subject: Re: KNumInput::setLabel and ugly dialogs Message-Id: <200804291911.00891.dhdev () gmx ! de> X-MARC-Message: https://marc.info/?l=kde-devel&m=120948913713444 On Sunday 27 April 2008, Holger Freyther wrote: > Hey, > > I toyed a bit with KDE4.0 and was a bit upset by setting dialogs like the > one attached to the screenshot. I looked a bit at the code and I lack > ideas how to fix the root cause. > > What these dialogs have in common are: > - One got some kind of a BoxLayout > - One adds a couple of KNumInput derived classes into the layout > - One uses KNumInput::setLabel > > As I said above I lack ideas how to fix the KNumInputs so that they align > properly. For kcm_keys I ditched the KNumInput::setLabel, created a label > myself, used QLabel::setBuddy and put everything into a QFormLayout. > Specially the last bit is the important one. By using a QFormLayout we > make sure the label and input area are properly aligned. > > Is there anything we can do to KNumInput to fix it? Using a layout, using > a QSpacerIterm? Provide a QLabel* KNumInput::label() and then put that > into a QFormLayout ourselves? > > comments > z. I wonder why we need the class at all: QLabel + QSpinBox usually should do the trick, then you can use a grid layout. Dominik >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<