[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Solid Network manager
From:       Thomas Gillespie <tomjamesgillespie () googlemail ! com>
Date:       2008-02-23 15:02:10
Message-ID: 200802231502.15320.tomjamesgillespie () googlemail ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi all, 

In the solid network manager backend, in the file NetworkManager-wirelessnetwo
rk.cpp, line 264, a false is added onto the dbus argument list. This will caus
e the connection to fail every time (line 70, nm-ap-security.c). Simply removi
ng this makes it all work fine (for me), but there is a "#warning fixme hardco
ded false fallback bool in setActiveDevice" two lines above it. Can anyone tel
l me why it is there, and what would be broken by removing it?

My svn diff:

Index: workspace/solid/networkmanager-0.6/NetworkManager-wirelessnetwork.cpp
===================================================================
--- workspace/solid/networkmanager-0.6/NetworkManager-wirelessnetwork.cpp       
(revision 778237)
+++ workspace/solid/networkmanager-0.6/NetworkManager-wirelessnetwork.cpp       
(working copy)
@@ -261,7 +261,7 @@
     QDBusObjectPath op(devicePath);
 #warning fixme hardcoded false fallback bool in setActiveDevice
     QList<QVariant> args;
-    args << qVariantFromValue(op) << d->essid << false;
+    args << qVariantFromValue(op) << d->essid;// << false;
     bool error;
     args = NMDBusHelper::serialize(d->authentication, d->essid, args, &error)
;
     kDebug(1441) << " " << args;


Thanks

Thomas

["signature.asc" (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]