[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    knetworkmanager deserialize bug
From:       Howard Chu <hyc () symas ! com>
Date:       2008-01-21 16:15:19
Message-ID: 4794C517.1020008 () symas ! com
[Download RAW message or body]

The nmu_security_deserialize_* functions all assume that the initial 
message_type argument was already consumed before they're called. 
knetworkmanager's dispatcher was leaving it in place, causing stuff like 
nmu_security_deserialize_wpa_eap() to always fail. Paranoid fix attached...
-- 
   -- Howard Chu
   Chief Architect, Symas Corp.  http://www.symas.com
   Director, Highland Sun        http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP     http://www.openldap.org/project/

["dif.txt" (text/plain)]

Index: knetworkmanager-nminfo_dbus.cpp
===================================================================
--- knetworkmanager-nminfo_dbus.cpp	(revision 764376)
+++ knetworkmanager-nminfo_dbus.cpp	(working copy)
@@ -318,6 +318,10 @@
 			break;
 		}
 		dbus_message_iter_get_basic (&iter, &we_cipher);
+		if (!dbus_message_iter_next (&iter))
+		{
+			kdWarning() << "int32 message argument 'we_cipher' was final element." << endl;
+		}
 
 		active_network->setEssid (QString::fromUtf8(essid));
 		active_network->insertHardwareAddress (bssid, true);


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]