[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Krazy exclude comments: usage
From:       "George Goldberg" <grundleborg () googlemail ! com>
Date:       2008-01-16 14:17:07
Message-ID: 1aa4e8880801160617u32fe5f7ejc16f65b3282d6462 () mail ! gmail ! com
[Download RAW message or body]

On Jan 16, 2008 9:38 PM, Allen Winter <winter@kde.org> wrote:
> On Tuesday 15 January 2008 22:29:16 George Goldberg wrote:
>
> > On Jan 14, 2008 10:45 PM, Allen Winter <winter@kde.org> wrote:
> > > You aren't doing anything wrong.
> > > You found a bug.
> > >
> > > I'll fix, hopefully before tonight's run.
> >
> > Did that get fixed? As I've just noticed that the comment:
> >
> > //krazy:exclude=doublequote_chars DOM demands chars
> >
> > that is present in a lot of KHTML files is not stopping krazy picking
> > these lines up. Is it the same bug, or is it the extra text after the
> > krazy instruction that is causing the problem?
> >
> There was no bug in Krazy.
> And Krazy was correct -- it was reporting lines that didn't have the exclude
> comment.

oh my mistake, sorry.

>
> To prevent this from happening again I'm adding a khtml/.krazy file with the
> "EXCLUDE doublequote_chars" line so this check will not be run on the
> khtml code.  Makes the khtml code prettier too -- I'm removing all those
> krazy:exclude comments.
>

sounds like a sensible idea!
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]