[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [Bug 154698] Won't open some TIFF files
From:       Pino Toscano <toscano.pino () tiscali ! it>
Date:       2007-12-28 1:36:07
Message-ID: 200712280236.12369.toscano.pino () tiscali ! it
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Alle venerd́ 28 dicembre 2007, James Richard Tyrer ha scritto:
> Pino Toscano wrote:
> > No, as okular "blindly" accepts what KMimeType reports (and, it could not
> > do else).
>
> Have you looked to see how GwenView does it.

Yes, and it's a totally different workflow.
Basically, gwenview just reads all the file contents, and tells QImageReader 
to read that data. No matter what image type that data represents, if there's 
a Qt image plugin to read that data, -> good, you have an image.
That's acceptable as long as the application is an *image* viewer (so, any 
file is good as long is an image).

> Since both Okular (front end -- the app) and GwenView can
> properly open the JPEG file with NO file extension, there is probably
> only a small difference which I consider a bug and would suggest that
> you fix it.

The difference is that a document viewer needs to know which kind of document 
is, and trying to read data to guess that
a) it's not correct (as it could be needed to read lot of data)
b) it's already done by KMimetype (once again we're here)

The only bug I see is the misdetection of your "TIFF" (really a JPEG) as TIFF 
by KMimeType (and btw, even gnomevfs does the same recognizing, based on the 
shared-mime-info database), and that's why your bug was reassigned by me to 
kdelibs (where KMimeType belongs).

-- 
Pino Toscano

["signature.asc" (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]