[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Encoding of startDir text wrong in KFileDialog
From:       Kevin Krammer <kevin.krammer () gmx ! at>
Date:       2007-12-12 21:54:33
Message-ID: 200712122254.37838.kevin.krammer () gmx ! at
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Wednesday 12 December 2007, Stephen Kelly wrote:
> Kevin Krammer wrote:
> > On Tuesday 11 December 2007, Stephen Kelly wrote:
> >> Hi,
> >>
> >> KUrl startLocation("Location with space");
> >> KFileDialog::getSaveUrl(startLocation);
> >>
> >> Creates a widget with filename "Location%20with%20space".
> >
> > Does it help if you explicitly tell KUrl that it is a path:
> >
> > KFileDialog::getSaveUrl(KUrl::fromPath("Location with space"));
> >
> > Cheers,
> > Kevin
>
> Yep, that's fixed the bug, thanks. It's still a workaround though, right?
> Something's still off in KFileDialog or KUrl...

It indicates a problem in the URL/path detection used in KUrl.
E.g. if you use KUrl::fromPathOrUrl it will likely also lead to the wrong 
string. Can you check this just to make sure?

Could you probably also give an example of such a "location with space", e.g. 
the string you have discovered the problem with?

Ideally you could provide a patch for the KUrl unittest which demonstrates the 
problem and which can then also serve to verify a solution and keep 
regressions detectable (kdelibs/kdecore/tests/kurltest.cpp

Cheers,
Kevin

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring

["signature.asc" (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]