'Re: [PATCH] kdebase/systemsettings: apply changes'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] kdebase/systemsettings: apply changes
From:       oreofish <oreofish () gmail ! com>
Date:       2007-11-27 8:09:35
Message-ID: 474BD0BF.1050705 () gmail ! com
[Download RAW message or body]

[Attachment #2 (text/html)]

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=x-gbk" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Thanks for your reply.<br>
I have tried to emit finished() in mainwindow, but it isn't work. I
think if emit finished() can work, the original codes should be OK.<br>
Then I add Mainwindow::closeEvent() to fix the problem. As you
mentioned, it breaks the encapsulation a bit.<br>
Hope there is a better solution.<br>
<br>
Aaron J. Seigo wrote:
<blockquote cite="mid:200711262319.06567.aseigo@kde.org" type="cite">
  <pre wrap="">On Monday 26 November 2007, xing rick wrote:
  </pre>
  <blockquote type="cite">
    <pre wrap="">The attached patch can fix the problem.
It will modify files in /kdebase/workspace/systemsettings/. Is it OK for
commit?
    </pre>
  </blockquote>
  <pre wrap=""><!---->
looks ok .. unfortunate to have to call this from mainwindow as it sort of 
breaks the encapsulation a bit,

i wonder why "emit finished()" is in KDialog::hideEvent rather that in 
KDialog::closeEvent ... that would probably also fix this issue. *shrug*

  </pre>
  <pre wrap="">
<hr size="4" width="90%">

  </pre>
  <blockquote type="cite">
    <blockquote type="cite">
      <pre wrap="">Visit <a class="moz-txt-link-freetext" \
href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub">http://mail.kde.org/mailman/listinfo/kde-devel#unsub</a> \
to unsubscribe &lt;&lt;  </pre>
    </blockquote>
  </blockquote>
</blockquote>
<br>
</body>
</html>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 