[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    KNode (3.5) Config dialog bug and fix
From:       Guillermo Antonio Amaral Bastidas <me () guillermoamaral ! com>
Date:       2007-09-14 0:59:10
Message-ID: 200709131759.16480.me () guillermoamaral ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


I found a bug in KNode's configuration dialog:

  Accounts > SMTP: if you have 'Server requires authentication' and 'Use 
external mailer' both checked, after dialog creation the 'User' 
and 'Password' Text Edits and Labels will be `Enabled` while everything else 
isn't.

I fixed it and can Commit as soon as I get somebody from KNode to give me the 
green flag.

Fix is attached for review.

Cheers,
GA

-- 
Guillermo Antonio Amaral Bastidas (gamaral)
# Free & Open-source Software Advocate
# KDE Developer: gamaral
@ http://blog.guillermoamaral.com/
$ irc: gamaral@freenode pgp: 0x5D297B74

["knode.patch" (text/x-diff)]

Index: knconfigwidgets.cpp
===================================================================
--- knconfigwidgets.cpp	(revision 712122)
+++ knconfigwidgets.cpp	(working copy)
@@ -709,10 +709,11 @@
 
 void KNConfig::SmtpAccountWidget::loginToggled( bool b )
 {
-  mUser->setEnabled( b );
-  mUserLabel->setEnabled( b );
-  mPassword->setEnabled( b );
-  mPasswordLabel->setEnabled( b );
+  bool canEnable = ( b && !mUseExternalMailer->isChecked() );
+  mUser->setEnabled( canEnable );
+  mUserLabel->setEnabled( canEnable );
+  mPassword->setEnabled( canEnable );
+  mPasswordLabel->setEnabled( canEnable );
   emit changed( true );
 }
 

["signature.asc" (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]