[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: kcm Emoticons theme creator/manager
From:       Carlo <brandon.ml () gmail ! com>
Date:       2007-08-23 14:20:13
Message-ID: 3262b6180708230720g526d3932q5d29f309500249a2 () mail ! gmail ! com
[Download RAW message or body]

thanks for the suggestions, i've fixed the errors
2007/8/22, Rafael Fernández López <ereslibre@gmail.com>:
> Hey,
>
> I find this interesting for all applications that use something similar to
> this.
>
> I really think you need to export this to a library, so all applications
> interested can use it.
>
> Some minor comments about the code:
>
> - On emoticonlist.cpp you are missing some i18n().
> - On emoticons.cpp some parts are not system safe (Linux, Windows...):
>
> new QFile(KGlobal::dirs()->saveLocation( "emoticons",
> name, false ) + "/emoticons.xml");
> emo = KGlobal::dirs()->findResource( "emoticons", themeName + '/' +
> de.attribute("file") + ".mng" );
> ...
>
> Please, consider using:
> http://doc.trolltech.com/4.3/qdir.html#separator.
>
>
> Bye and thanks for your work,
> Rafael Fernández López.
>
>
> >> Visit
> http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe <<
>
>

["emoticons.tar.bz2" (application/x-bzip2)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]