[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Query on kdelibs/kdecore/io/kgrantpty.c
From:       Brad Hards <bradh () frogmouth ! net>
Date:       2007-07-29 7:15:54
Message-ID: 200707291716.00118.bradh () frogmouth ! net
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


I'm doing some experiments with a static checker, and my initial rule checks 
threw up a lot of errors, possibly many false alarms [dear lazyweb, is it an 
error to  do FooClass *p = new FooClass; p->member = bar; without checking if 
p is null?]

One that does look like an error is in kgrantpty.c
Around line 149 is this line:
    tty = malloc(strlen(pty) + 1);

That never gets free()'d that I can see. 

Does that count as a bug, or is it OK because this is a standalone application 
and it gets cleaned up on exit?

Brad

[Attachment #5 (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]