[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] Bug 113177: Trim whitespace for "open selection as URL"
From:       Andreas Hartmetz <ahartmetz () gmail ! com>
Date:       2007-06-04 20:27:18
Message-ID: 200706042227.18884.ahartmetz () gmail ! com
[Download RAW message or body]

On Monday 04 June 2007 21:48:33 Thiago Macieira wrote:
> Andreas Hartmetz wrote:
> >> > +    url.replace(QRegExp("[\\ ]*\\n+[\\ ]*"),"");
> >
> >How about
> >url = url.trimmed();
> >?
> >
> >Faster, easier, safer. C++ is, fortunately, not Perl x)
> >
> >Good catch by the way. I've had to redo a selection to make konqueror
> >recognize an URL more than once.
>
> I thought the same thing when I read the email first, but that's not what
> the regexp is doing.
>
> It's removing any newlines, including the spaces around it, wherever they
> are located (including the middle of the string).

Alright. The comment even says it. Nah.
:/
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]