[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Some EBN fixes
From:       Stephen Leaf <smileaf () smileaf ! org>
Date:       2007-05-16 17:14:04
Message-ID: 200705161214.04900.smileaf () smileaf ! org
[Download RAW message or body]

On Tuesday 15 May 2007 14:23:08 Nicolas Lécureuil wrote:
> Hi,
>
> i fixes some EBN on kdebase ( TRUE / FALSE and QMIN / QMAX ). I attached my
> patch.
>
> I hope it can be commited.
>
>
> Regards
>
> Nicolas

Just a small thing that I noticed, you might wanna check that "whole words 
only" option when you go to do the find/replace. Otherwise you get lines 
like:
#ifndef QT_NO_IMAGE_TRUECOLOR
Getting changed to:
#ifndef QT_NO_IMAGE_trueCOLOR 
which will cause problems.

Also being true and false should be defined on all systems isn't that kind of 
redundant? Was there a reason to set TRUE to 1?
-- 
Stephen Leaf
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]