[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [patch] fixes for stuff ebn doesn't like (tm) about
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2007-02-18 23:19:17
Message-ID: 200702181619.20098.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On February 18, 2007, Simon Schmeißer wrote:
> hi everyone
>
> so here comes yet another episode of "fixes for stuff ebn doesn't like"
> (tm) ;-)

if you're going to keep this up (and i hope you do =) you should get your own 
svn account to be able to commit such fixes...

> this time it's for kdeaddons/kfile-plugins

committed

> kdeaddons/konq-plugins 

-  bool createDirectory(QDir thumb_dir, QString imgGalleryDir, QString 
dirName);
+  bool createDirectory(QDir &thumb_dir, const QString &imgGalleryDir, const 
QString &dirName);

this looks wrong, since the method modifies the QDir object. it should 
probably be a const QDir& with a local copy being made in the createDirectory 
method..

the fsviewpart ctor doesn't need to be explicit (it has three params with no 
defaults), though the other two classes in the file did need explicit 
ctors...

committed with above changes...

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

Full time KDE developer sponsored by Trolltech (http://www.trolltech.com)

[Attachment #5 (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]