This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--===============1683283226==
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enigE5218F5DC959423A92DFB7FB"

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigE5218F5DC959423A92DFB7FB
Content-Type: multipart/mixed;
 boundary="------------020300060308060306020308"

This is a multi-part message in MIME format.
--------------020300060308060306020308
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

I have prepared a patch implementing often-requested wish (218 votes) -
changing color of fonts in taskbar (see
https://bugs.kde.org/show_bug.cgi?id=3D118460).

Any comments welcome, it is my first patch involving .kcfg and .ui, so I
might have messed something up :)

If it is OK, I would like to commit it during next feature unfreeze for
stable branch (it is for 3.5.x, not for KDE4).

If necessary, I can submit it to kde-usability for review.

Here are the screenshots (they are with Polish text as KControl does not
seem to respect KDE_LANG variable):
Config window with custom colors disabled:
http://lichota.net/~krzysiek/projects/kde/taskbar-colors/config-custom-co=
lors-inactive.png

Config window with custom colors enabled:
http://lichota.net/~krzysiek/projects/kde/taskbar-colors/config-custom-co=
lors-active.png

Taskbar with "Classic" appearance:
http://lichota.net/~krzysiek/projects/kde/taskbar-colors/custom-colors-cl=
assic.png

Taskbar with "Elegant" appearance:
http://lichota.net/~krzysiek/projects/kde/taskbar-colors/custom-colors-el=
egant.png

Taskbar with "For transparency" appearance and transparent Kicker:
http://lichota.net/~krzysiek/projects/kde/taskbar-colors/custom-colors-tr=
ansparency.png

Colors on screenshots have been chosen for demonstration, not because of
their beauty :)

	Krzysztof Lichota



--------------020300060308060306020308
Content-Type: text/x-patch;
 name="taskbar-colors2.diff"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline;
 filename="taskbar-colors2.diff"

Index: kcontrol/taskbar/kcmtaskbar.cpp
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- kcontrol/taskbar/kcmtaskbar.cpp	(wersja 569913)
+++ kcontrol/taskbar/kcmtaskbar.cpp	(kopia robocza)
@@ -30,6 +30,8 @@
 #include <kdialog.h>
 #include <kgenericfactory.h>
 #include <kwin.h>
+#include <kcolorbutton.h>
+#include <qlabel.h>
=20
 #define protected public
 #include "kcmtaskbarui.h"
@@ -151,7 +153,9 @@
=20
     connect(m_widget->kcfg_GroupTasks, SIGNAL(activated(int)),
             this, SLOT(slotUpdateComboBox()));
+    connect(m_widget->kcfg_UseCustomColors, SIGNAL(stateChanged(int)), t=
his, SLOT(slotUpdateCustomColors()));
=20
+    slotUpdateCustomColors();
     updateAppearanceCombo();
=20
     if (KWin::numberOfDesktops() < 2)
@@ -182,6 +186,18 @@
     QTimer::singleShot(0, this, SLOT(notChanged()));
 }
=20
+void TaskbarConfig::slotUpdateCustomColors()
+{
+    m_widget->kcfg_ActiveTaskTextColor->setEnabled(m_widget->kcfg_UseCus=
tomColors->isChecked());
+    m_widget->activeTaskTextColorLabel->setEnabled(m_widget->kcfg_UseCus=
tomColors->isChecked());
+   =20
+    m_widget->kcfg_InactiveTaskTextColor->setEnabled(m_widget->kcfg_UseC=
ustomColors->isChecked());
+    m_widget->inactiveTaskTextColorLabel->setEnabled(m_widget->kcfg_UseC=
ustomColors->isChecked());
+   =20
+    m_widget->kcfg_TaskBackgroundColor->setEnabled(m_widget->kcfg_UseCus=
tomColors->isChecked());
+    m_widget->taskBackgroundColorLabel->setEnabled(m_widget->kcfg_UseCus=
tomColors->isChecked());
+}
+
 void TaskbarConfig::slotUpdateComboBox()
 {
     int pos =3D TaskBarSettings::ActivateRaiseOrMinimize;
Index: kcontrol/taskbar/kcmtaskbar.h
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- kcontrol/taskbar/kcmtaskbar.h	(wersja 569913)
+++ kcontrol/taskbar/kcmtaskbar.h	(kopia robocza)
@@ -64,6 +64,7 @@
     void slotUpdateComboBox();
     void appearanceChanged(int);
     void notChanged();
+    void slotUpdateCustomColors();
=20
 private:
     TaskbarAppearance::List m_appearances;
Index: kcontrol/taskbar/kcmtaskbarui.ui
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- kcontrol/taskbar/kcmtaskbarui.ui	(wersja 569913)
+++ kcontrol/taskbar/kcmtaskbarui.ui	(kopia robocza)
@@ -177,6 +177,141 @@
                         <cstring>appearance</cstring>
                     </property>
                 </widget>
+                <widget class=3D"QCheckBox" row=3D"9" column=3D"0" rowsp=
an=3D"1" colspan=3D"2">
+                    <property name=3D"name">
+                        <cstring>kcfg_UseCustomColors</cstring>
+                    </property>
+                    <property name=3D"enabled">
+                        <bool>true</bool>
+                    </property>
+                    <property name=3D"text">
+                        <string>Use &amp;custom colors</string>
+                    </property>
+                    <property name=3D"accel">
+                        <string>Alt+C</string>
+                    </property>
+                    <property name=3D"checked">
+                        <bool>true</bool>
+                    </property>
+                </widget>
+                <widget class=3D"QLayoutWidget" row=3D"10" column=3D"0" =
rowspan=3D"1" colspan=3D"3">
+                    <property name=3D"name">
+                        <cstring>layout9</cstring>
+                    </property>
+                    <grid>
+                        <property name=3D"name">
+                            <cstring>unnamed</cstring>
+                        </property>
+                        <spacer row=3D"1" column=3D"2">
+                            <property name=3D"name">
+                                <cstring>spacer11_2</cstring>
+                            </property>
+                            <property name=3D"orientation">
+                                <enum>Horizontal</enum>
+                            </property>
+                            <property name=3D"sizeType">
+                                <enum>Expanding</enum>
+                            </property>
+                            <property name=3D"sizeHint">
+                                <size>
+                                    <width>191</width>
+                                    <height>20</height>
+                                </size>
+                            </property>
+                        </spacer>
+                        <widget class=3D"KColorButton" row=3D"0" column=3D=
"1">
+                            <property name=3D"name">
+                                <cstring>kcfg_InactiveTaskTextColor</cst=
ring>
+                            </property>
+                            <property name=3D"text">
+                                <string></string>
+                            </property>
+                        </widget>
+                        <spacer row=3D"0" column=3D"2">
+                            <property name=3D"name">
+                                <cstring>spacer11</cstring>
+                            </property>
+                            <property name=3D"orientation">
+                                <enum>Horizontal</enum>
+                            </property>
+                            <property name=3D"sizeType">
+                                <enum>Expanding</enum>
+                            </property>
+                            <property name=3D"sizeHint">
+                                <size>
+                                    <width>191</width>
+                                    <height>20</height>
+                                </size>
+                            </property>
+                        </spacer>
+                        <widget class=3D"KColorButton" row=3D"2" column=3D=
"1">
+                            <property name=3D"name">
+                                <cstring>kcfg_TaskBackgroundColor</cstri=
ng>
+                            </property>
+                            <property name=3D"text">
+                                <string></string>
+                            </property>
+                        </widget>
+                        <widget class=3D"QLabel" row=3D"2" column=3D"0">=

+                            <property name=3D"name">
+                                <cstring>taskBackgroundColorLabel</cstri=
ng>
+                            </property>
+                            <property name=3D"text">
+                                <string>&amp;Background color:</string>
+                            </property>
+                            <property name=3D"buddy" stdset=3D"0">
+                                <cstring>kcfg_TaskBackgroundColor</cstri=
ng>
+                            </property>
+                        </widget>
+                        <widget class=3D"KColorButton" row=3D"1" column=3D=
"1">
+                            <property name=3D"name">
+                                <cstring>kcfg_ActiveTaskTextColor</cstri=
ng>
+                            </property>
+                            <property name=3D"text">
+                                <string></string>
+                            </property>
+                        </widget>
+                        <widget class=3D"QLabel" row=3D"0" column=3D"0">=

+                            <property name=3D"name">
+                                <cstring>inactiveTaskTextColorLabel</cst=
ring>
+                            </property>
+                            <property name=3D"text">
+                                <string>Inacti&amp;ve task text color:</=
string>
+                            </property>
+                            <property name=3D"buddy" stdset=3D"0">
+                                <cstring>kcfg_InactiveTaskTextColor</cst=
ring>
+                            </property>
+                        </widget>
+                        <widget class=3D"QLabel" row=3D"1" column=3D"0">=

+                            <property name=3D"name">
+                                <cstring>activeTaskTextColorLabel</cstri=
ng>
+                            </property>
+                            <property name=3D"text">
+                                <string>Active task te&amp;xt color:</st=
ring>
+                            </property>
+                            <property name=3D"buddy" stdset=3D"0">
+                                <cstring>kcfg_ActiveTaskTextColor</cstri=
ng>
+                            </property>
+                        </widget>
+                        <spacer row=3D"2" column=3D"2">
+                            <property name=3D"name">
+                                <cstring>spacer12</cstring>
+                            </property>
+                            <property name=3D"orientation">
+                                <enum>Horizontal</enum>
+                            </property>
+                            <property name=3D"sizeType">
+                                <enum>Expanding</enum>
+                            </property>
+                            <property name=3D"sizeHint">
+                                <size>
+                                    <width>191</width>
+                                    <height>20</height>
+                                </size>
+                            </property>
+                        </spacer>
+                    </grid>
+                </widget>
                 <spacer row=3D"1" column=3D"0">
                     <property name=3D"name">
                         <cstring>spacer2</cstring>
@@ -323,10 +458,16 @@
     <tabstop>kcfg_ShowAllWindows</tabstop>
     <tabstop>kcfg_SortByDesktop</tabstop>
     <tabstop>showAllScreens</tabstop>
+    <tabstop>kcfg_SortByApp</tabstop>
     <tabstop>kcfg_ShowOnlyIconified</tabstop>
     <tabstop>kcfg_ShowIcon</tabstop>
     <tabstop>kcfg_ShowWindowListBtn</tabstop>
     <tabstop>kcfg_GroupTasks</tabstop>
+    <tabstop>appearance</tabstop>
+    <tabstop>kcfg_UseCustomColors</tabstop>
+    <tabstop>kcfg_InactiveTaskTextColor</tabstop>
+    <tabstop>kcfg_ActiveTaskTextColor</tabstop>
+    <tabstop>kcfg_TaskBackgroundColor</tabstop>
     <tabstop>kcfg_LeftButtonAction</tabstop>
     <tabstop>kcfg_MiddleButtonAction</tabstop>
     <tabstop>kcfg_RightButtonAction</tabstop>
@@ -336,4 +477,9 @@
 </includes>
 <layoutdefaults spacing=3D"3" margin=3D"6"/>
 <layoutfunctions spacing=3D"KDialog::spacingHint" margin=3D"KDialog::mar=
ginHint"/>
+<includehints>
+    <includehint>kcolorbutton.h</includehint>
+    <includehint>kcolorbutton.h</includehint>
+    <includehint>kcolorbutton.h</includehint>
+</includehints>
 </UI>
Index: kicker/taskbar/taskbar.kcfg
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- kicker/taskbar/taskbar.kcfg	(wersja 633266)
+++ kicker/taskbar/taskbar.kcfg	(kopia robocza)
@@ -149,5 +149,25 @@
             <label>Maximum width/height of the thumbnail in pixels</labe=
l>
             <whatsthis>A thumbnail is created by resizing the window. Th=
e scaling factor is determined by its largest dimension and this value. I=
n doing so, the thumbnail's size will not exceed this value in any dimens=
ion.</whatsthis>
         </entry>
+        <entry key=3D"UseCustomColors" type=3D"Bool" >
+            <default>false</default>
+            <label>Use custom colors for taskbar buttons text and backgr=
ound</label>
+            <whatsthis>Turning this option on will allow choosing your o=
wn colors for taskbar buttons text and background.</whatsthis>
+        </entry>
+        <entry name=3D"ActiveTaskTextColor" type=3D"Color" >
+            <label>Color to use for active task button text</label>
+            <default code=3D"true">QColor()</default>
+            <whatsthis>This color is used for displaying text on taskbar=
 button for task which is active at the moment.</whatsthis>
+        </entry>
+        <entry name=3D"InactiveTaskTextColor" type=3D"Color" >
+            <label>Color to use for inactive tasks button text</label>
+            <default code=3D"true">QColor()</default>
+            <whatsthis>This color is used for displaying text on taskbar=
 button for tasks other than active.</whatsthis>
+        </entry>
+        <entry name=3D"TaskBackgroundColor" type=3D"Color" >
+            <label>Color to use for taskbar buttons background</label>
+            <default code=3D"true">QColor()</default>
+            <whatsthis>This color is used for displaying background of t=
askbar buttons.</whatsthis>
+        </entry>
     </group>
 </kcfg>
Index: kicker/taskbar/taskcontainer.cpp
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- kicker/taskbar/taskcontainer.cpp	(wersja 633266)
+++ kicker/taskbar/taskcontainer.cpp	(kopia robocza)
@@ -544,6 +544,15 @@
     font.setBold(active);
=20
     QColorGroup colors =3D palette().active();
+   =20
+    if (TaskBarSettings::useCustomColors())
+    {
+        colors.setColor( QColorGroup::Button, TaskBarSettings::taskBackg=
roundColor());
+        colors.setColor( QColorGroup::Background, TaskBarSettings::taskB=
ackgroundColor() );
+        colors.setColor( QColorGroup::ButtonText, TaskBarSettings::inact=
iveTaskTextColor() );
+        colors.setColor( QColorGroup::Text, TaskBarSettings::inactiveTas=
kTextColor() );
+    }
+   =20
     if (demandsAttention)
     {
         if (!drawButton)
@@ -682,7 +691,14 @@
         }
         else // hack for the dotNET style and others
         {
-            textPen =3D p->pen();
+            if (TaskBarSettings::useCustomColors())
+            {
+                textPen =3D QPen(TaskBarSettings::activeTaskTextColor())=
;
+            }
+            else
+            {
+                textPen =3D p->pen();
+            }
         }
=20
         int availableWidth =3D width() - (br.x() * 2) - textPos;

--------------020300060308060306020308--

--------------enigE5218F5DC959423A92DFB7FB
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF0v5tSHJB/1EhaUwRAm9oAKC7zj/iSG0HOZlL3hupX/ym4L+ZzwCfY1Bd
KjI47a1OS/DmnqXoNkxnInA=
=dhil
-----END PGP SIGNATURE-----

--------------enigE5218F5DC959423A92DFB7FB--

--===============1683283226==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

--===============1683283226==--