[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [patch] i18n-issue kaudiocreator - please review
From:       Benjamin Meyer <ben () meyerhome ! net>
Date:       2006-11-13 21:36:34
Message-ID: 200611132236.35861.ben () meyerhome ! net
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 13 November 2006 6:07 pm, Thomas Reitelbach wrote:
> Hello list,
>
> can someone please have a look at the mini-patch for kaudiocreator
> (branches)?
>
> It fixes a minor issue with l10n. The CDDB edit dialog does currently
> display english strings, even if the corresponding strings (which are from
> libkcddb.po) are translated.
> The reason: kaudiocreator must use an additional Catalogue for KLocale, but
> doesn't.
>
> The patch inserts the additional catalogue.
>
> I'd like to commit the patch for 3.5 and trunk, please review.
>
> Cheers,
> Thomas
>
> Patch:
> Index: main.cpp
> ===================================================================
> --- main.cpp    (Revision 604656)
> +++ main.cpp    (Arbeitskopie)
> @@ -41,6 +41,10 @@
>    KCmdLineArgs::addCmdLineOptions( options );
>    KApplication a(argc, argv);
>    KAudioCreator *app = new KAudioCreator(0, "MainWindow");
> +
> +  // we need some strings from libkcddb for the cddb album dialog
> +  KGlobal::locale()->insertCatalogue("libkcddb");
> +
>    a.setMainWidget(app);
>
>    KCmdLineArgs* args = KCmdLineArgs::parsedArgs();

That looks fine, feel free to commit

-Benjamin Meyer

-- 
aka icefox
Public Key: http://www.icefox.net/public_key.asc

[Attachment #5 (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]