[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: kdelibs/kutils/kpluginselector rewriting
From:       Matt Rogers <mattr () kde ! org>
Date:       2006-10-27 1:04:19
Message-ID: 200610262004.19960.mattr () kde ! org
[Download RAW message or body]

On Thursday 26 October 2006 18:25, Rafael Fernández López wrote:
> Hi,
>
> Since I've been looking something to improve on Kopete, hermier suggested
> me to take a look to "kpluginselector". It is a bit broken, since when
> dragging the QSplitter, no redrawing in the left side... well, from my
> point of view the class was a bit tricky.
>
> I have rewritten it, the work *IS NOT FINISHED YET* but I'd like you to
> tell me what you think and what should I change, before sending the last
> patch. If you replace this files with yours on
> kdelibs/kutils/kpluginselector.cpp and kdelibs/kutils/kpluginselector.h it
> will compile and run successfully, but no changes will be saved when
> Accepting changes, and the "Apply" button won't became enabled if any
> configuration is changed in any module. I have to port the "dependencies"
> stuff yet.
>
> By the way, kdelibs/kutils/kpluginselector_p.h is not needed anymore.
>
> Bye,
> Rafael Fernández López.

Is there a reason that you felt compelled to rewrite KPluginSelector which 
generally works fine already? Why didn't you reuse what was already there and 
just fix the behavior of the splitter?
--
Matt
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]