[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Some kicker issues
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2006-10-23 6:01:10
Message-ID: 200610230001.11156.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thursday 19 October 2006 11:57, Rafael Fernández López wrote:
> I just want to know if this is going the right way and I'd like you to tell
> me what things are going well in the porting, and what things should be
> improved.

the patch is really hard to read due to the amount of commented out code =/

in any case... the model approach is probably good. i'd suggest putting the 
calls to PluginManager inside the model itself; better encapsulation that 
way.

it looks like some of the methods aren't complete, which is understandable 
since you said you weren't finished yet ;) if you could clean the patch up 
(less commented out code, for isntance) and complete the implementation we 
can probably merge it into trunk/ 

-- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

Full time KDE developer sponsored by Trolltech (http://www.trolltech.com)

[Attachment #5 (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]