[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Still possible to commit new features for 3.5.5 ?
From:       David Faure <faure () kde ! org>
Date:       2006-09-27 9:46:34
Message-ID: 200609271146.35545.faure () kde ! org
[Download RAW message or body]

On Sunday 24 September 2006 13:09, Brad Hards wrote:
> I am not the maintainer of kdialog - David Faure is. 
Hmm, I thought you were the de-facto maintainer by now ;)
Actually... you are the maintainer in bugzilla; since you were handling all the bugs
I thought you might as well get them directly... I see from the line above
that this was a mistake, I really thought you considered yourself the maintainer by now.
Sorry about that; shall I change it back?

> On Friday 22 September 2006 04:24, Juan Luis Baptiste wrote: 
> Index: kdeui/kprogress.cpp
> ===================================================================
> --- kdeui/kprogress.cpp (revision 587244)
> +++ kdeui/kprogress.cpp (working copy)
> @@ -233,6 +233,11 @@
>      return mCancelled;
>  }
> 
> +void KProgressDialog::dontCancel()
> +{
> +    mCancelled = false;
> +}
> +
>  bool KProgressDialog::wasCancelled() const
>  {
>      return mCancelled;
> Index: kdeui/kprogress.h
> ===================================================================
> --- kdeui/kprogress.h   (revision 587244)
> +++ kdeui/kprogress.h   (working copy)
> @@ -327,6 +327,13 @@
>          bool wasCancelled() const;
> 
>          /**
> +         * Cancels the last "cancel" action if the cancel button was
> +         * pressed. Useful for kdialog when combined with a KMessageBox
> +         * to display a message like "Are you sure you want to cancel?"
There should be a " * @since 3.5.5" here.
> +         */
> +        void dontCancel();

> I'm not sure about the dontCancel name for the method but I couldn't come up 
> with a better one.

Right, cancelCancel would be confusing ;)
What about ignoreCancel()?

Ok for the patch in any case, makes sense. Interestingly QProgressDialog doesn't have
this possibility either, AFAICS.

Please forwardport as well (trunk/KDE/kdelibs/kdeui/dialogs/kprogressdialog.*
and trunk/KDE/kdebase/apps/kdialog/*, stuff has moved around a bit)

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]