[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: PATCH: KTar Does Not Recognize Differently Enabled Checksums
From:       David Faure <faure () kde ! org>
Date:       2006-07-22 5:42:43
Message-ID: 200607220742.43769.faure () kde ! org
[Download RAW message or body]

On Sunday 16 July 2006 18:58, Robert Hogan wrote:
> 
> Following on from my disregarded yelp a couple of days ago I've wasted an hour 
> or two of a beautiful sunny Sunday afternoon figuring out KTar's difficulty 
> with funny checksums.

Then it wasn't wasted :)

> Whatever the crew at Dante have used to tarball their source, 
> it 'right-justifies' checksum values in the checksum field so that what would 
> normally appear as 010334 appears as 0010334.
> 
> The attached fixes this for KTar by trying to match the checksum in three 
> different positions on the header block rather than just the one. 

OK.

> Can you please, please commit this for the next bugfix release of 3.5 
Hehe, this is why you provided a patch for trunk? ;-)

Anyway - I committed to trunk and adapted to 3.5-branch too.
Thanks for the patch!

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]