[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: keditbookmarks issue with $VARS
From:       David Faure <faure () kde ! org>
Date:       2006-06-18 21:11:29
Message-ID: 200606182311.29874.faure () kde ! org
[Download RAW message or body]

On Sunday 18 June 2006 00:46, Daniel Teske wrote:
> 
> > 
> > For Konsole, users would like to have bookmarks such as:
> > ssh user machine 'echo $HOSTNAME'
> > 
> > This works as expected.
> > However, the below doesn't.  It appears the the Bookmark Editor automatically 
> > lowercases any $VARIABLE in the URL textentry.
> > 
> > ssh://user machine 'echo $HOSTNAME'
> > will automatically get replaced by
> > ssh://user machine 'echo $hostname'
> > in the edit textbox.
> > 
> > This appears to be an issue in konqueror/keditbookmarks.  Is this a known 
> > issue and is there anyway to get around it?
> > Regards,
> > Kurt
> > 
> > http://bugs.kde.org/show_bug.cgi?id=88867  
> 
> Oh, well. What is happening is that the string is converted into an KURL, which \
> automatically lowercases the hostname. (KURL obviously considers the whole string \
> the hostname.) So the fix would be to treat the address everywhere as a string \
> instead as a KURL. Hmm, I don't know how much work that would be. (And currently \
> don't have the time to work on this.)

Hmm, but then we can have all sorts of invalid urls in our bookmarks, plus useless \
reparsing... How about using valid urls for konsole bookmarks instead?
Something like
   ssh://user@machine?cmd='echo $HOSTNAME'
where
  KUrl::host() returns machine, and
  KUrl::queryItem("cmd") returns 'echo $HOSTNAME'.
(see next kurltest commit, I tested this in trunk only, but it should work in kde3 \
too)

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

 
> > Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]