--===============0801048287==
Content-Type: multipart/signed;
  boundary="nextPart1789951.OmDNLDDOlU";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart1789951.OmDNLDDOlU
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Greg Martyn wrote:
>1. But think of the SVN history!
>Regardless of the validity of this complaint, the damage has already
>been done. It's not as bad as some may think though -- svn blame
>survives a svn mv, so the only lines affected are those that contain
>"ksysguard." (not to mention that svn blame can take a revision number
>as an argument)

I don't mind the mvs, but I do mind the unnecessary script-modifying of=20
the source code. Why do you need to rename all the classes? Just leave=20
the old names.

Besides, your automatic renaming of everything broke the compilation,=20
which shows you modified a lot more lines than you had to. This is where=20
you lose precious history.

So, if you need to rename the icons, make sure only the icon names are=20
changed in the source code. If you decide to rename a class or two, make=20
sure it's only those classes that will be renamed.

I'd suggest you svn rm and start again from "ksysguard". And compile your=20
code before submitting.

=2D-=20
Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
  thiago.macieira (AT) trolltech.com     Trolltech AS
    GPG: 0x6EF45358                   |  Sandakerveien 116,
    E067 918B B660 DBD1 105C          |  NO-0402
    966C 33F5 F005 6EF4 5358          |  Oslo, Norway

--nextPart1789951.OmDNLDDOlU
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)

iD8DBQBEhbTOM/XwBW70U1gRAp4OAJ9ErQnSXsH4xrYOl930O6pZ88a2uwCeO1zR
GdpOmGyEm0xEiaCcKMcDMos=
=ulEP
-----END PGP SIGNATURE-----

--nextPart1789951.OmDNLDDOlU--

--===============0801048287==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

--===============0801048287==--