[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: what is the point of KAction::setDefaultShortcut() ?
From:       Christian Loose <christian.loose () hamburg ! de>
Date:       2006-05-04 20:47:39
Message-ID: 445A686B.7060008 () hamburg ! de
[Download RAW message or body]

Hamish Rodda schrieb:
> On Wednesday 03 May 2006 02:10, Jason Harris wrote:
>   
>> On Tuesday 02 May 2006 06:18, Hamish Rodda wrote:
>>     
>>> Default is so that it is simple to offer "revert to default" in the
>>> shortcut configure dialog.  I reworked this recently so that setShortcut
>>> sets _both_ the default and the custom value (prior to checking if there
>>> is a custom shortcut in the config file), so that's what you'll generally
>>> want to use.
>>>       
>> Ok, but is it a bug that setting the Default shortcut without setting the
>> Custom shortcut results in no shortcut at all?  Why isn't the default used
>> in this case?  Just curious; calling "setDefaultShortcut()" when you want a
>> shortcut seems intuitively correct to me.
>>     
>
> No, it's not a bug, it is the intended behaviour.  The Custom shortcut is the 
> active shortcut, and the Default shortcut is the shortcut we copy over to the 
> Custom field if the user chooses default shortcuts in the dialog.
>
> However perhaps it is badly named, so if you can suggest something else I 
> would appreciate it.
>
>   

If setShortcut() sets both shortcuts (custom and default), in what 
use-cases would you only use setDefaultShortcut()?
ATM it sounds like setDefaultShortcut() could be removed.

Bye, Christian
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]